Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE bring-up: Differentiate NODE_TAGS from NODE_INSTANCE_PREFIX #29141

Merged
merged 1 commit into from
Jul 19, 2016
Merged

GCE bring-up: Differentiate NODE_TAGS from NODE_INSTANCE_PREFIX #29141

merged 1 commit into from
Jul 19, 2016
+21 −3

Conversation

zmerlynn
Copy link
Member

Kubernetes-side fix to #29074 (GKE-side fix necessary as well)

@zmerlynn
GCE bring-up: Differentiate NODE_TAGS from NODE_INSTANCE_PREFIX
4c667c3 
Kubernetes-side fix to kubernetes#29074 (GKE-side fix necessary as well)
@zmerlynn zmerlynn added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherrypick-candidate labels Jul 18, 2016
@zmerlynn zmerlynn added this to the v1.3 milestone Jul 18, 2016
@foxish
Copy link
Contributor

foxish commented Jul 18, 2016

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 18, 2016

GCE e2e build/test passed for commit 4c667c3.

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1d91996 into kubernetes:master Jul 19, 2016
@fabioy fabioy added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 19, 2016
@fabioy
Copy link
Contributor

fabioy commented Jul 19, 2016

@zmerlynn Cherrypick approved. Please create a cherrypick PR. Thanks.

@zmerlynn zmerlynn mentioned this pull request Jul 19, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 19, 2016
Merge pull request #29210 from zmerlynn/automated-cherry-pick-of-#291…
aef4d84 
…41-upstream-release-1.3

Automatic merge from submit-queue

Automated cherry pick of #29141

Cherry pick of #29141 on release-1.3.
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#29210 from zmerlynn/automated-cherry-pi…
4eb0898 
…ck-of-#29141-upstream-release-1.3

Automatic merge from submit-queue

Automated cherry pick of kubernetes#29141

Cherry pick of kubernetes#29141 on release-1.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@a-robinson a-robinson

@roberthbailey roberthbailey

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
9 participants
@zmerlynn @foxish @k8s-bot @k8s-github-robot @fabioy @k8s-cherrypick-bot @googlebot @a-robinson @roberthbailey