Improve quota controller performance by eliminating unneeded list calls #29134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XS
derekwaynecarr
added
release-note-none
derekwaynecarr
changed the title
derekwaynecarr
changed the title
derekwaynecarr
force-pushed
the
quota_improvement
branch
from
14073fb to
ebcc637
Compare
|
lgtm, unit test for this one ought to be pretty straightforward though |
derekwaynecarr
force-pushed
the
quota_improvement
branch
from
ebcc637 to
f2f65fe
Compare
|
@deads2k - now with tests that verify ;-) |
|
Labelling this PR as size/S |
k8s-github-robot
added
size/S
|
GCE e2e build/test passed for commit f2f65fe. |
deads2k
added
the
lgtm
|
@derekwaynecarr let's get picks. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit f2f65fe. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when syncing quota usage, we asked each registered
Evaluatorto determine the usage it knows to track associated with aGroupKindeven if that particularGroupKindhad no associated resources under quota.This fix makes it that when we sync a quota that just had only
Podrelated compute resources, we do not also calculate the usage stats for things likeConfigMap,Secret, etc. per quota.This should be a significant performance gain when running large numbers of
Namespace's each withResourceQuotathat tracks a subset of resources./cc @deads2k @kubernetes/rh-cluster-infra