Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change maxsize to size in logrotate. #29128

Merged
merged 1 commit into from
Jul 18, 2016
Merged

Change maxsize to size in logrotate. #29128

merged 1 commit into from
Jul 18, 2016
+2 −2

Conversation

bprashanth
Copy link
Contributor

How do I trigger a test? I usually test logrotate with logrotate -s and that works as expected.

@bprashanth bprashanth added this to the v1.3 milestone Jul 18, 2016
@bprashanth bprashanth mentioned this pull request Jul 18, 2016
Closed
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 18, 2016
@zmerlynn zmerlynn added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 18, 2016
@zmerlynn
Copy link
Member

Fix in Salt LGTM, not sure about GCI? @adityakali?

@adityakali
Copy link
Contributor

Please update it at https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/configure-helper.sh#L95 as well.
Thanks!

@bprashanth
Copy link
Contributor Author

Done, PTAL

@zmerlynn zmerlynn added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jul 18, 2016
@bprashanth
Copy link
Contributor Author

I'm adding cherry-pick, unless someone objects. @roberthbailey as cherry pick czar (or whatever that role is).

@zmerlynn zmerlynn added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 18, 2016
@adityakali
Copy link
Contributor

LGTM. Thanks!

@k8s-bot
Copy link

k8s-bot commented Jul 18, 2016

GCE e2e build/test passed for commit 1173dd1.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 18, 2016

GCE e2e build/test passed for commit 1173dd1.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit bbc09d5 into kubernetes:master Jul 18, 2016
@bprashanth bprashanth mentioned this pull request Jul 19, 2016
Closed
@bprashanth bprashanth removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Jul 19, 2016
@bprashanth bprashanth removed this from the v1.3 milestone Jul 19, 2016
@bprashanth
Copy link
Contributor Author

subsumed by #29139, so removed cherrypick labels

@roberthbailey
Copy link
Contributor

Do they need to be cherry picked together though (since that one built on top of this one)?

@bprashanth
Copy link
Contributor Author

@roberthbailey the options added in #29139 essentially revert this pr. Those options are more reliable to avoid file name collisions for log rotate in spans > 1s (and we shouldn't be filling up maxsize in 1s, hopefully).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

@adityakali adityakali

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bprashanth @zmerlynn @adityakali @k8s-bot @k8s-github-robot @roberthbailey @googlebot