I think you'll need to hit hack/jenkins/gotest-dockerized.sh and build/common.sh's KUBE_BUILD_IMAGE_CROSS_TAG as well.

thanks! updated!

Looks good to me 👍

GCE e2e build/test passed for commit a333cf4.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

LGTM, thanks.

On a side note, we should probably document all these places to bump the version somewhere. When I went to 1.6.1 or 1.6.2 I missed one and it took a long time to realize it.

yes I was thinking of even simplifying it by catting a file or something?

On Mon, Jul 18, 2016 at 5:14 PM, Joe Finney notifications@github.com
wrote:

On a side note, we should probably document all these places to bump the
version somewhere. When I went to 1.6.1 or 1.6.2 I missed one and it took a
long time to realize it.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#29127 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbMUy9x-gR8s2YTPdYfNBhtUZQR4vks5qW-zCgaJpZM4JO-9Q
.

That works for some things but we don't always have the source tree handy when we're doing things. In particular, hack/jenkins/dockerized-e2e-runner.sh is curled from github without the rest of the source.

@spxtr ah makes sense then I can add some docs, do you have a preferred location?

I don't really know a good location. Presumably somewhere in docs/, but I'm worried it will go out of date like just about everything else over there.

LGTM! :)
docs/devel is for developers, but not sure how up-to-date those docs are.

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit a333cf4.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue