Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PD E2E Tests Wait for Detach to Prevent Kernel Errors #29031

Merged
merged 1 commit into from
Jul 16, 2016

Conversation

saad-ali
Copy link
Member

Fixes #28854

@saad-ali saad-ali added cherrypick-candidate release-note-none Denotes a PR that doesn't merit a release note. labels Jul 15, 2016
@saad-ali saad-ali added this to the v1.3 milestone Jul 15, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 15, 2016
@saad-ali
Copy link
Member Author

Ran E2E tests back to back for 9 hours with these changes and saw 0 instances of the kernel errors mentioned in #28854

@matchstick matchstick added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 16, 2016

GCE e2e build/test passed for commit ce0e976.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 51629f5 into kubernetes:master Jul 16, 2016
@fabioy fabioy added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 19, 2016
@fabioy
Copy link
Contributor

fabioy commented Jul 19, 2016

@saad-ali Cherrypick approved. Please create a cherrypick PR. Thanks.

fabioy added a commit that referenced this pull request Jul 26, 2016
@fabioy fabioy added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 26, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants