Fix the fix for taint scheduler predicate test #29003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-t
added
the
lgtm
|
Merging to unbreak the test |
|
The failure is caused by the change of removing taint (originally expected taint removed before relaunching the pod, but we do need also make sure taint are removed when the test exit with error). I will try to fix it. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Jul 29, 2016
…s-e2e Automatic merge from submit-queue Remove redundant pod deletion in scheduler predicates tests and fix taints-tolerations e2e ~~In scheduler predicates test, some tests won't clean pods they created when exit with failure, which may lead to pod leak. This PR is to fix it.~~ Remove redundant pod deletion in scheduler predicates tests, since framework.AfterEach() already did the cleanup work after every test. Also fix the test "validates that taints-tolerations is respected if not matching", refer to the change on taint-toleration test in #29003, and #24134 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.