Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions on turning on dynamic provisioning for testing. #28978

Merged
merged 1 commit into from
Jul 16, 2016

Conversation

foxish
Copy link
Contributor

@foxish foxish commented Jul 14, 2016

HostPath volumes are not automatically provisioned unless we pass in --enable-hostpath-provisioner to the controller manager. This was not mentioned in the docs previously, leading to questions like this.

HostPath volumes are not automatically provisioned unless we pass in `--enable-hostpath-provisioner` to the controller manager. This was not mentioned in the docs previously.
@foxish
Copy link
Contributor Author

foxish commented Jul 14, 2016

@erictune PTAL

@erictune
Copy link
Member

Thanks for fixing this.
LGTM

@erictune erictune added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2016
@erictune erictune added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 16, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 16, 2016

GCE e2e build/test passed for commit 80d4800.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3a305c1 into kubernetes:master Jul 16, 2016
@foxish foxish deleted the patch-1 branch July 16, 2016 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants