cc @kubernetes/sig-testing

@spiffxp thx for pointing out,
Is there some document describing framework or just self describing code ;) ?

LGTM

I think it may also fix #27655

GCE e2e build/test passed for commit 1d7ee42.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Need LGTM after rebase

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit 1d7ee42.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue

This most likely broke MaxPods test - master node is not schedulable, so we don't put master machine on the list, which means we're not correctly filtering out pods in getPodsScheduled function. Reverting.

Correct fix would be to add a check in the else part of the loop:

for _, node := range nodes.Items {
            if system.IsMasterNode(&node) {
                masterNodes.Insert(node.Name)
            } else {
                nodeList.Items = append(nodeList.Items, node)
            }
        }

though it's not needed for our jenkins setup. It won't solve taints, as GetReadySchedulableNodesOrDie looks only if the Node (and it's network) is ready, and checks the Unschedulable bit in NodeSpec and ignores taints.