Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the name of the secret that delivers federation kubeconfig. #28938

Merged
merged 1 commit into from
Jul 20, 2016
Merged

Change the name of the secret that delivers federation kubeconfig. #28938

merged 1 commit into from
Jul 20, 2016

Conversation

madhusudancs
Copy link
Contributor

@madhusudancs madhusudancs commented Jul 14, 2016 •
edited by k8s-oncall
Loading

The current name, federation-apiserver-secret, is very similar to the
other secret we have, federation-apiserver-secrets, that delivers
somewhat similar data but in a different format. This is extremely
confusing, particularly while debugging.

This change should soothe the pain.

cc @kubernetes/sig-cluster-federation

This change is Reviewable

@madhusudancs madhusudancs added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/cluster-federation labels Jul 14, 2016
@madhusudancs madhusudancs added this to the v1.4 milestone Jul 14, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 14, 2016
@madhusudancs madhusudancs force-pushed the fed14-kubeconfig-secret-name branch 2 times, most recently from ae7f822 to 21699fb Compare July 14, 2016 07:32
@mml
Copy link
Contributor

mml commented Jul 14, 2016

How do users roll forward to this new setting, and roll back? (E.g., when moving between 1.3 and the eventual 1.4)

@madhusudancs madhusudancs added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 14, 2016
@madhusudancs
Copy link
Contributor Author

@mml thanks for pointing that out. I think mentioning that in release note as action required is the best thing we can do at this point. I added a command to migrate the secret from one to the other. PTAL.

@mml
Copy link
Contributor

mml commented Jul 14, 2016

As discussed in person, we'll let both names work for one release.

@madhusudancs
Copy link
Contributor Author

@mml done. PTAL!

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2016
mml
mml reviewed Jul 15, 2016
View reviewed changes
federation/cmd/federation-controller-manager/app/controllermanager.go
// favor of the new name but giving people time to migrate.
// TODO(madhusudancs): this name is deprecated in 1.4 and should be
// removed in 1.5. Remove it in 1.5.
DeprecatedKubeconfigSecretName = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this should be empty string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mml Missed that by accident, sorry about that. PTAL now.

@madhusudancs madhusudancs force-pushed the fed14-kubeconfig-secret-name branch from 0022b0e to 4f93870 Compare July 18, 2016 22:46
@mml
Copy link
Contributor

mml commented Jul 19, 2016

LGTM. Add label after you squash, @madhusudancs

@madhusudancs
Change the name of the secret that delivers federation kubeconfig.
3ac2ab3 
The current name, federation-apiserver-secret, is very similar to the
other secret we have, federation-apiserver-secrets, that delivers
somewhat similar data but in a different format. This is extremely
confusing, particularly while debugging.

This change should soothe the pain.
@madhusudancs madhusudancs force-pushed the fed14-kubeconfig-secret-name branch from 4f93870 to 3ac2ab3 Compare July 19, 2016 19:27
@madhusudancs
Copy link
Contributor Author

Squashed. Adding the label.

@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 20, 2016

GCE e2e build/test passed for commit 3ac2ab3.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 20, 2016

GCE e2e build/test passed for commit 3ac2ab3.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit c305c39 into kubernetes:master Jul 20, 2016
@madhusudancs madhusudancs mentioned this pull request Aug 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mml mml

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@madhusudancs @mml @k8s-bot @k8s-github-robot @googlebot