Allow switching rate limiter inside RateLimitedQueue #28882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarek
added
the
do-not-merge
k8s-github-robot
added
size/M
gmarek
added
release-note-none
|
|
||
| // SwapLimiter safely swaps current limiter for this queue with the passed one if capacities or qps's differ. | ||
| func (q *RateLimitedTimedQueue) SwapLimiter(limiter flowcontrol.RateLimiter) { | ||
| if q.limiter.Capacity() == limiter.Capacity() && q.limiter.QPS() == limiter.QPS() { |
There was a problem hiding this comment.
This is accessing q.limitted, so also should be done under lock (potentially a different thread can SwapLimitters at the same time.
k8s-github-robot
added
kind/api-change
| newLimiter = flowcontrol.NewTokenBucketRateLimiter(newQPS, evictionRateLimiterBurst) | ||
| } | ||
| // If we're currently waiting on limiter, we drain the new one - this is best effort approach. | ||
| for q.limiter.Saturation() > newLimiter.Saturation() { |
There was a problem hiding this comment.
Well, in case of all limitters have Burst=1 it doesn't matter, but I still think that this method of saturation is bad.
Can you please at least add a TODO to consider changing it to be more numer-of-calls-oriented (as I described previously?).
|
One comment. |
|
Done. @wojtek-t PTAL |
gmarek
added
release-note
wojtek-t
added
the
lgtm
|
LGTM |
|
GCE e2e build/test passed for commit f6b1c31. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit f6b1c31. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #28832
cc @davidopp