[client-gen] Allow passing subresources in Patch method #28820
Conversation
caesarxuchao
added
the
sig/api-machinery
k8s-github-robot
added
size/XL
caesarxuchao
force-pushed
the
patch-subresource
branch
from
91569ab to
a115542
Compare
k8s-github-robot
added
the
needs-rebase
caesarxuchao
force-pushed
the
patch-subresource
branch
from
a115542 to
c2fb391
Compare
k8s-github-robot
removed
the
needs-rebase
|
Something weird happens to the node e2e: |
|
@k8s-bot node e2e test this, issue #IGNORE |
caesarxuchao
changed the title
|
GCE e2e build/test passed for commit c2fb391. |
| @@ -23,7 +23,7 @@ import ( | |||
|
|
|||
| func (c *FakeNodes) PatchStatus(nodeName string, data []byte) (*api.Node, error) { | |||
| obj, err := c.Fake.Invokes( | |||
| core.NewPatchSubresourceAction(nodesResource, "status"), &api.Node{}) | |||
There was a problem hiding this comment.
How was this line generated before? I don't see any manual change that adds nodename and data to the calling of NewPatchSubresourceAction.
There was a problem hiding this comment.
Files end with "_expansion" are manually written.
There was a problem hiding this comment.
oh, ok. Because it was in a commit called "generated changes", I assumed they are auto generated. make sense to me know. The change looks good in respect to actual code change, I am still trying to understand the whole client set, but no need to block this PR for that.
There was a problem hiding this comment.
Sorry for the confusion :P
mbohlool
added
the
lgtm
k8s-github-robot
removed
the
lgtm
mbohlool
added
release-note-none
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit c2fb391. |
|
Automatic merge from submit-queue |
Expand the Patch() method from:
to
Continue on #27293. Fixes #26580.
cc @Random-Liu @lavalamp