Add --quiet to hide the 'waiting for pods to be running' message in kubectl run #28801

janetkuo · 2016-07-11T21:41:20Z

@kubernetes/kubectl

j3ffml · 2016-07-11T21:49:30Z

pkg/kubectl/cmd/run.go

@@ -117,9 +117,11 @@ func addRunFlags(cmd *cobra.Command) {
 	cmd.Flags().Bool("expose", false, "If true, a public, external service is created for the container(s) which are run")
 	cmd.Flags().String("service-generator", "service/v2", "The name of the generator to use for creating a service.  Only used if --expose is true")
 	cmd.Flags().String("service-overrides", "", "An inline JSON override for the generated service object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field.  Only used if --expose is true.")
+	cmd.Flags().Bool("silent", false, "If true, hide the 'waiting for pod to be running' message")


What do you think about making this a top-level flag? It's a common use case to run a command and ignore output.

Did you mean we make it a global flag?

What'd other messages to be hidden? Something like when kubectl delete pod/foo --silent we don't print pod "foo" deleted but only print error messages?

What'd other messages to be hidden? Something like when kubectl delete pod/foo --silent we don't print pod "foo" deleted but only print error messages?

Yep, only print error messages. When passing --silent you would rely on the return code to determine whether command succeeded.

Maybe we should get this in one place first and then come back later and
make it global. I'd like us to refactor the PrinterCommand stuff because
it's not aligned with how we do option structs (ideally we'd create an
option struct that we invoke bind on for the default printer options, and
hide retrieving the printer logic from commands).

On Mon, Jul 11, 2016 at 6:35 PM, Jeff Lowdermilk notifications@github.com
wrote:

In pkg/kubectl/cmd/run.go
#28801 (comment)
:

@@ -117,9 +117,11 @@ func addRunFlags(cmd *cobra.Command) {
cmd.Flags().Bool("expose", false, "If true, a public, external service is created for the container(s) which are run")
cmd.Flags().String("service-generator", "service/v2", "The name of the generator to use for creating a service. Only used if --expose is true")
cmd.Flags().String("service-overrides", "", "An inline JSON override for the generated service object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field. Only used if --expose is true.")

cmd.Flags().Bool("silent", false, "If true, hide the 'waiting for pod to be running' message")

What'd other messages to be hidden? Something like when kubectl delete
pod/foo --silent we don't print pod "foo" deleted but only print error
messages?

Yep, only print error messages. When passing --silent you would rely on
the return code to determine whether command succeeded.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/pull/28801/files/deb67df071895d8eb9e41a1ac8c3d46c7fcef768#r70349834,
or mute the thread
https://github.com/notifications/unsubscribe/ABG_px5dVODgN287dOhxlfU8Z9Ey7BUoks5qUsUwgaJpZM4JJz6B
.

Help text says this hides the waiting for pods running output. Is there other output from the command? It would be more intuitive if --silent hid all output except errors.

Isn't this normally "quiet"? I'm trying to search man on my system for a
rough count of either, but it's taking too long.

On Mon, Jul 11, 2016 at 6:43 PM, Clayton Coleman ccoleman@redhat.com
wrote:

Maybe we should get this in one place first and then come back later and
make it global. I'd like us to refactor the PrinterCommand stuff because
it's not aligned with how we do option structs (ideally we'd create an
option struct that we invoke bind on for the default printer options, and
hide retrieving the printer logic from commands).

On Mon, Jul 11, 2016 at 6:35 PM, Jeff Lowdermilk <notifications@github.com

wrote:

In pkg/kubectl/cmd/run.go
#28801 (comment)
:

@@ -117,9 +117,11 @@ func addRunFlags(cmd *cobra.Command) {
cmd.Flags().Bool("expose", false, "If true, a public, external service is created for the container(s) which are run")
cmd.Flags().String("service-generator", "service/v2", "The name of the generator to use for creating a service. Only used if --expose is true")
cmd.Flags().String("service-overrides", "", "An inline JSON override for the generated service object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field. Only used if --expose is true.")

cmd.Flags().Bool("silent", false, "If true, hide the 'waiting for pod to be running' message")

What'd other messages to be hidden? Something like when kubectl delete
pod/foo --silent we don't print pod "foo" deleted but only print error
messages?

Yep, only print error messages. When passing --silent you would rely on
the return code to determine whether command succeeded.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/pull/28801/files/deb67df071895d8eb9e41a1ac8c3d46c7fcef768#r70349834,
or mute the thread
https://github.com/notifications/unsubscribe/ABG_px5dVODgN287dOhxlfU8Z9Ey7BUoks5qUsUwgaJpZM4JJz6B
.

I would worry that "--silent" here might be interpreted to mean "show no
log output, only return an exit code if you can get the pod"

On Mon, Jul 11, 2016 at 6:49 PM, Clayton Coleman ccoleman@redhat.com
wrote:

Isn't this normally "quiet"? I'm trying to search man on my system for a
rough count of either, but it's taking too long.

On Mon, Jul 11, 2016 at 6:43 PM, Clayton Coleman ccoleman@redhat.com
wrote:

Maybe we should get this in one place first and then come back later and
make it global. I'd like us to refactor the PrinterCommand stuff because
it's not aligned with how we do option structs (ideally we'd create an
option struct that we invoke bind on for the default printer options, and
hide retrieving the printer logic from commands).

On Mon, Jul 11, 2016 at 6:35 PM, Jeff Lowdermilk <
notifications@github.com> wrote:

In pkg/kubectl/cmd/run.go
#28801 (comment)
:

@@ -117,9 +117,11 @@ func addRunFlags(cmd *cobra.Command) {
cmd.Flags().Bool("expose", false, "If true, a public, external service is created for the container(s) which are run")
cmd.Flags().String("service-generator", "service/v2", "The name of the generator to use for creating a service. Only used if --expose is true")
cmd.Flags().String("service-overrides", "", "An inline JSON override for the generated service object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field. Only used if --expose is true.")

cmd.Flags().Bool("silent", false, "If true, hide the 'waiting for pod to be running' message")

What'd other messages to be hidden? Something like when kubectl delete
pod/foo --silent we don't print pod "foo" deleted but only print error
messages?

Yep, only print error messages. When passing --silent you would rely on
the return code to determine whether command succeeded.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/pull/28801/files/deb67df071895d8eb9e41a1ac8c3d46c7fcef768#r70349834,
or mute the thread
https://github.com/notifications/unsubscribe/ABG_px5dVODgN287dOhxlfU8Z9Ey7BUoks5qUsUwgaJpZM4JJz6B
.

@smarterclayton Agreed. Since it'd still generate some "sound", --quiet would make more sense.

janetkuo · 2016-07-12T17:24:33Z

PTAL

smarterclayton · 2016-07-12T17:49:20Z

pkg/kubectl/cmd/run.go

@@ -117,9 +117,11 @@ func addRunFlags(cmd *cobra.Command) {
 	cmd.Flags().Bool("expose", false, "If true, a public, external service is created for the container(s) which are run")
 	cmd.Flags().String("service-generator", "service/v2", "The name of the generator to use for creating a service.  Only used if --expose is true")
 	cmd.Flags().String("service-overrides", "", "An inline JSON override for the generated service object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field.  Only used if --expose is true.")
+	cmd.Flags().Bool("quiet", false, "If true, hide the 'waiting for pod to be running' message")


For future proofing, maybe say "only print output from the running pods" or similar?

…ubectl run

janetkuo · 2016-07-12T18:58:22Z

pkg/kubectl/cmd/run.go

@@ -117,9 +117,11 @@ func addRunFlags(cmd *cobra.Command) {
 	cmd.Flags().Bool("expose", false, "If true, a public, external service is created for the container(s) which are run")
 	cmd.Flags().String("service-generator", "service/v2", "The name of the generator to use for creating a service.  Only used if --expose is true")
 	cmd.Flags().String("service-overrides", "", "An inline JSON override for the generated service object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field.  Only used if --expose is true.")
+	cmd.Flags().Bool("quiet", false, "If true, suppress prompt messages.")


Changed the usage of --quiet to If true, suppress prompt messages.

k8s-bot · 2016-07-12T19:46:47Z

GCE e2e build/test passed for commit 268b93e.

k8s-github-robot · 2016-07-12T23:03:40Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-07-12T23:36:55Z

GCE e2e build/test passed for commit 268b93e.

k8s-github-robot · 2016-07-12T23:37:22Z

Automatic merge from submit-queue

Automatic merge from submit-queue Add test for --quiet flag for kubectl run This adds a test for the changes introduced in #30247 and #28801. Ref #28695

googlebot added the cla: yes label Jul 11, 2016

janetkuo added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 11, 2016

j3ffml reviewed Jul 11, 2016
View reviewed changes

k8s-github-robot assigned smarterclayton Jul 11, 2016

k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 11, 2016

janetkuo force-pushed the kubectl-run-silent branch from deb67df to 7012fa4 Compare July 12, 2016 00:02

janetkuo changed the title ~~Add --silent to hide the 'waiting for pods to be running' message in kubectl run~~ Add --quiet to hide the 'waiting for pods to be running' message in kubectl run Jul 12, 2016

janetkuo mentioned this pull request Jul 12, 2016

kubectl run doesn’t work for simple "run command, parse result" #28695

Closed

smarterclayton reviewed Jul 12, 2016
View reviewed changes

Add --quiet to hide the 'waiting for pods to be running' message in k…

268b93e

…ubectl run

janetkuo force-pushed the kubectl-run-silent branch from 7012fa4 to 268b93e Compare July 12, 2016 18:57

janetkuo reviewed Jul 12, 2016
View reviewed changes

smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2016

k8s-github-robot merged commit 0efd038 into kubernetes:master Jul 12, 2016

ardnaxelarak mentioned this pull request Aug 16, 2016

Add test for --quiet flag for kubectl run #30701

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add --quiet to hide the 'waiting for pods to be running' message in kubectl run #28801

Add --quiet to hide the 'waiting for pods to be running' message in kubectl run #28801

janetkuo commented Jul 11, 2016

j3ffml Jul 11, 2016

janetkuo Jul 11, 2016 •

edited

Loading

j3ffml Jul 11, 2016

smarterclayton Jul 11, 2016

j3ffml Jul 11, 2016

j3ffml Jul 11, 2016

smarterclayton Jul 11, 2016

smarterclayton Jul 11, 2016

janetkuo Jul 11, 2016

janetkuo commented Jul 12, 2016

smarterclayton Jul 12, 2016

janetkuo Jul 12, 2016

k8s-bot commented Jul 12, 2016

k8s-github-robot commented Jul 12, 2016

k8s-bot commented Jul 12, 2016

k8s-github-robot commented Jul 12, 2016

Add --quiet to hide the 'waiting for pods to be running' message in kubectl run #28801

Add --quiet to hide the 'waiting for pods to be running' message in kubectl run #28801

Conversation

janetkuo commented Jul 11, 2016

Choose a reason for hiding this comment

janetkuo Jul 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janetkuo commented Jul 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-bot commented Jul 12, 2016

k8s-github-robot commented Jul 12, 2016

k8s-bot commented Jul 12, 2016

k8s-github-robot commented Jul 12, 2016

janetkuo Jul 11, 2016 •

edited

Loading