Retry when apiserver fails to listen on insecure port #28797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
|
/cc @kubernetes/sig-api-machinery |
|
Retrying forever doesn't seem quite right, but since you are doing exactly what the secure port is doing I won't make you revisit that. LGTM |
lavalamp
added
lgtm
|
Marking as release note because people might want to verify that a health check is enabled in their configurations, so that this won't cause them to launch a non functional apiserver that never crashes. |
|
Error seems to be unrelated to this PR. |
|
@k8s-bot test this please github issue: #IGNORE |
|
Not sure if I can do that, but figured I'd try. |
|
GCE e2e build/test passed for commit 25ac0dd. |
|
Looks good to me 👍 |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 25ac0dd. |
|
Automatic merge from submit-queue |
peebs
pushed a commit
to peebs/kubernetes
that referenced
this pull request
Jul 26, 2016
This is a backport of: kubernetes#28797
aaronlevy
added a commit
to aaronlevy/kubernetes
that referenced
this pull request
Aug 1, 2016
This is a backport of: kubernetes#28797
peebs
pushed a commit
to peebs/kubernetes
that referenced
this pull request
Aug 12, 2016
This is a backport of: kubernetes#28797
aaronlevy
added a commit
to aaronlevy/kubernetes
that referenced
this pull request
Aug 27, 2016
This is a backport of: kubernetes#28797
aaronlevy
added a commit
to coreos/kubernetes
that referenced
this pull request
Sep 13, 2016
This is a backport of: kubernetes#28797
aaronlevy
added a commit
to coreos/kubernetes
that referenced
this pull request
Sep 28, 2016
This is a backport of: kubernetes#28797
aaronlevy
added a commit
to coreos/kubernetes
that referenced
this pull request
Oct 20, 2016
This is a backport of: kubernetes#28797
aaronlevy
added a commit
to coreos/kubernetes
that referenced
this pull request
Nov 1, 2016
This is a backport of: kubernetes#28797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apiserver will already continually retry when it fails to bind to the secure port. However, with the insecure port it does not retry, and any failures cause the apiserver to exit.
This change makes it so the api-server will retry on both insecure/secure ports.
A use-case for this change is for self-hosting the api-server, particularly when you are only running a single copy in your cluster. In some bootstrap and upgrade scenarios - it's necessary to replace/pivot from an existing api-server on the same host -- where you need a new copy running before tearing down the old (which is problematic when the api-server will try to bind to an in-use port and exit).