Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: kube-up respects AZURE_RESOURCE_GROUP #28700

Merged
merged 1 commit into from
Aug 2, 2016
Merged

azure: kube-up respects AZURE_RESOURCE_GROUP #28700

merged 1 commit into from
Aug 2, 2016
+7 −11

Conversation

colemickens
Copy link
Contributor

This fixes #28482.

  • declare AZKUBE_ variables as global to workaround lack of bash support for exporting array variables

@colemickens
azure kube-up respects AZURE_RESOURCE_GROUP
8b1bd66 
This fixes kubernetes#28482.

declare AZKUBE_ variables as global to workaround
lack of bash support for exporting array variables
@colemickens colemickens mentioned this pull request Jul 8, 2016
Closed
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jul 8, 2016
runemy pushed a commit to Uninett/azure that referenced this pull request Jul 13, 2016
https://github.com/kubernetes/kubernetes/pull/28700
2c55355
@TsuyoshiUshio
Copy link

TsuyoshiUshio commented Jul 24, 2016 •
edited
Loading

I hope this PR is merged quickly.

Unless this, we can't use service principal authentication. 👍
The service principal authentication works well when I change the following line. However, colemichens's change is much more essential than mine. :)

            --client-id="${AZURE_CLIENT_ID}" \
            --client-secret="${AZURE_CLIENT_SECRET}" \

Thank you colemickens.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. retest-not-required-docs-only and removed retest-not-required-docs-only labels Jul 28, 2016
@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Aug 1, 2016
@brendandburns
Copy link
Contributor

LGTM, sorry for the delay.

@brendandburns brendandburns assigned brendandburns and unassigned eparis Aug 1, 2016
@brendandburns
Copy link
Contributor

@k8s-bot test this please issue: #27462

@brendandburns
Copy link
Contributor

@k8s-bot kubernetes-e2e-gke-test this please issue: #27462

@brendandburns
Copy link
Contributor

@k8s-bot e2e test this issue: #27462

@k8s-bot
Copy link

k8s-bot commented Aug 2, 2016

GCE e2e build/test passed for commit 8b1bd66.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 81ab15c into kubernetes:master Aug 2, 2016
@colemickens colemickens deleted the azure-kube-up-fix-env-var branch August 30, 2016 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

util.sh in cluster/azure/ seems to be trying to export Bash arrays, but that's not supported
7 participants
@colemickens @TsuyoshiUshio @brendandburns @k8s-bot @k8s-github-robot @googlebot @eparis