Update coreos node e2e image to a version that uses cgroupfs #28661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
k8s-github-robot
added
size/S
|
GCE e2e build/test passed for commit 7524b49ea95175b7c8ebea37224484395eeaf7c4. |
dubstack
force-pushed
the
dubstack-update-coreos
branch
from
7524b49 to
b38eb05
Compare
dubstack
added
release-note
| if [ $# -ne 4 ]; then | ||
| print_usage | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
nit: can you assign the positional arguments to named variables? I find it much more readable that way
e.g. FROM_IMAGE=$1, etc.
|
/cc @euank |
|
GCE e2e build/test passed for commit b38eb0573bc18a2f4b383bf1fa4db077a6443e4d. |
dubstack
force-pushed
the
dubstack-update-coreos
branch
from
b38eb05 to
fb7f18f
Compare
|
@timstclair nit addressed. PTAL. |
k8s-github-robot
added
size/M
|
GCE e2e build/test passed for commit fb7f18f. |
|
@yifan-gu Can you add LGTM? |
vishh
added
lgtm
|
Bumping up priority since this PR is blocking other feature PRs. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit fb7f18f. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #28192. This PR updates coreos node e2e image to a version that uses cgroupfs.
cc @vishh @yifan-gu