Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't delete affinity when endpoints are empty #28655

Merged
merged 3 commits into from
Jul 8, 2016
Merged

Don't delete affinity when endpoints are empty #28655

merged 3 commits into from
Jul 8, 2016

Conversation

freehan
Copy link
Contributor

@freehan freehan commented Jul 8, 2016

closes: #25316

@freehan freehan added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherrypick-candidate labels Jul 8, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 8, 2016

GCE e2e build/test passed for commit e1df5c8.

@thockin thockin added this to the v1.3 milestone Jul 8, 2016
@thockin thockin added cherrypick-candidate lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 8, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 8, 2016

GCE e2e build/test failed for commit e1df5c8.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@wojtek-t
Copy link
Member

wojtek-t commented Jul 8, 2016

@k8s-bot e2e test this please, issue: #27503

@k8s-bot
Copy link

k8s-bot commented Jul 8, 2016

GCE e2e build/test passed for commit e1df5c8.

@k8s-bot
Copy link

k8s-bot commented Jul 8, 2016

GCE e2e build/test passed for commit e1df5c8.

@freehan
Copy link
Contributor Author

freehan commented Jul 8, 2016

exceed CPU quota
@k8s-bot test this issue: #IGNORE

@k8s-bot
Copy link

k8s-bot commented Jul 8, 2016

GCE e2e build/test passed for commit e1df5c8.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 8, 2016

GCE e2e build/test passed for commit e1df5c8.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 04602bb into kubernetes:master Jul 8, 2016
@fabioy fabioy added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 19, 2016
@fabioy
Copy link
Contributor

fabioy commented Jul 19, 2016

@freehan Cherrypick approved. Please create a cherrypick PR. Thanks.

@thockin thockin mentioned this pull request Jul 19, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 19, 2016
Merge pull request #29069 from thockin/automated-cherry-pick-of-#2865…
ad52402 
…5-upstream-release-1.3

Automatic merge from submit-queue

Automated cherry pick of #28655 upstream release 1.3

Cherry pick of #28655 on release-1.3.

Cherry-picking for @freehan since he is out.
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#29069 from thockin/automated-cherry-pic…
13b9a42 
…k-of-#28655-upstream-release-1.3

Automatic merge from submit-queue

Automated cherry pick of kubernetes#28655 upstream release 1.3

Cherry pick of kubernetes#28655 on release-1.3.

Cherry-picking for @freehan since he is out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
8 participants
@freehan @k8s-cherrypick-bot @k8s-bot @wojtek-t @k8s-github-robot @fabioy @googlebot @thockin