-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for not checking in generated, part 2/2 #28579
Prep for not checking in generated, part 2/2 #28579
Conversation
GCE e2e build/test passed for commit 00ec4fd4a2599d783efdcfe51b67cb244ac34414. |
00ec4fd
to
8708f59
Compare
GCE e2e build/test passed for commit 8708f5954c3c3c35993f3329fc736410c5a2d8f5. |
@thockin - an you please rebase? |
This is just comment clarity.
This was causing us to process packages we didn't really want, which was only visible when debugging was enabled.
This is to clarify the intent of the code for new readers (me).
This is to clarify the code. No actual effect at the moment, but I manually verified this in the case of identical types.
This is used subsequently to simplify the conversion generation, so each package can declare what peer-packages it uses, and have those imported dynamically, rather than having one mega list of packages to import and not really being clear why, for any given list item.
This drives conversion generation from file tags like: // +conversion-gen=k8s.io/my/internal/version .. rather than hardcoded lists of packages. The only net change in generated code can be explained as correct. Previously it didn't know that conversion was available.
There are ample opportunities to optimize and streamline here. For example, there's no reason to have a function to convert IntStr to IntStr. Removing the function does generate the right assignment, but it is unclear whether the registered function is needed or not. I opted to leave it alone for now. Another example is Convert_Slice_byte_To_Slice_byte, which just seems silly.
This fixes PodSpec to generate cleanly. No other types only half-generate (so now we Fatalf), though several fail to generate at all (only Errorf for now).
8708f59
to
a892b26
Compare
@wojtek-t part 1 is in, this is now rebased onto it. |
Yes - I've seen part 1 is in. Will look into this one in few minutes. |
You're awesome! I owe you a drink or a meal or something :) On Thu, Jul 7, 2016 at 10:14 PM, Wojciech Tyczynski <
|
GCE e2e build/test passed for commit a892b26. |
LGTM |
rebased twice in 24 hours. Making p2. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit a892b26. |
Automatic merge from submit-queue |
This PR is extracted from #25978 and build on #28578 - it is just the conversion related parts. All the Makefile stuff is excluded.
@wojtek-t this is literally branched, a bunch of commits deleted, and a very small number of manual fixups applied. If you think this is easier to review (and if it passes CI) you can feel free to go over it again. I will follow this with a conversion-related PR to build on this.
Or if you prefer, just close this and let the mega-PR ride.
@lavalamp