Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable extensions/v1beta1/NetworkPolicy by default #28549

Merged
merged 4 commits into from
Jul 8, 2016
Merged

Enable extensions/v1beta1/NetworkPolicy by default #28549

merged 4 commits into from
Jul 8, 2016

Conversation

caseydavenport
Copy link
Member

@caseydavenport caseydavenport commented Jul 6, 2016 •
edited
Loading

Fixes #28401

For some reason this also triggered an update to the swagger spec (which apparently hadn't been done before but wasn't failing validation...)

@caseydavenport
Copy link
Member Author

I still need to test this works.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 6, 2016
@caseydavenport caseydavenport mentioned this pull request Jul 6, 2016
Closed
@k8s-bot
Copy link

k8s-bot commented Jul 6, 2016

GCE e2e build/test passed for commit 93c6e87374707772d2cec09b11c20d3f4b2ee835.

@caseydavenport caseydavenport mentioned this pull request Jul 6, 2016
Closed
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 6, 2016

GCE e2e build/test passed for commit c381831006d942068bc99e413541f3aa8bc3b695.

@k8s-bot
Copy link

k8s-bot commented Jul 6, 2016

GCE e2e build/test passed for commit 43d4ed233f552ae13cadc4f07397102534a0c1a8.

@caseydavenport
Copy link
Member Author

I've tested that this works using the vagrant provider - the NetworkPolicy resource is indeed enabled by default.

@k8s-bot
Copy link

k8s-bot commented Jul 7, 2016

GCE e2e build/test passed for commit 53744f3e92532927894ff42fd47643d7cce56862.

@thockin
Copy link
Member

thockin commented Jul 7, 2016

LGTM. @derekwaynecarr are you OK to review this or should we get someone else? We'll want to cherry-pick the min-set of this into 1.3.1.

Jenkins says: Please run hack/update-api-reference-docs.sh

@matchstick FYI

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 7, 2016

GCE e2e build/test passed for commit e9fbffdd98fb66762deaa0783fb7496606d81cd2.

@k8s-bot
Copy link

k8s-bot commented Jul 7, 2016

GCE e2e build/test passed for commit ea4be05.

@caseydavenport
Copy link
Member Author

OK - auto generation completed and all checks passing :)

What are we considering the minimum set that must be cherry-picked? It seems like there is a bunch of API documentation that wasn't generated the first time around for some reason that should probably be cherry picked as well.

@thockin thockin added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 8, 2016
@thockin
Copy link
Member

thockin commented Jul 8, 2016

The min-set should be the master.go and docs.

@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2016
@thockin thockin added this to the v1.3 milestone Jul 8, 2016
@thockin
Copy link
Member

thockin commented Jul 8, 2016

I think this will have to be a manual or semi-manual cherrypick

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 8, 2016

GCE e2e build/test passed for commit ea4be05.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2296108 into kubernetes:master Jul 8, 2016
@thockin
Copy link
Member

thockin commented Jul 17, 2016

did we get a cherry-pick for this?

@caseydavenport
Copy link
Member Author

caseydavenport commented Jul 18, 2016 •
edited
Loading

@thockin - I don't think so. What is the process for a manual / semi-manual cherry-pick?

Also, what is the process to get the API docs changes propagated through to kubernetes.io?

@fabioy fabioy added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 24, 2016
@fabioy
Copy link
Contributor

fabioy commented Jul 24, 2016

@caseydavenport Cherrypick approved. Please create a cherrypick PR for this off the 1.3 release branch (not 1.3.0). Thank you.

@caseydavenport
Copy link
Member Author

@fabioy thanks, I've opened #29556

@caseydavenport caseydavenport deleted the cd-default-netpol branch June 20, 2017 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
7 participants
@caseydavenport @k8s-bot @thockin @k8s-github-robot @fabioy @googlebot @derekwaynecarr