Please add a test

@polvi I don't follow your comment in the original issue: "there appears to be a race in kubectl for the ability to read the APIs". I think kubectl is single-threaded, why would there be a race?

I think this PR is correct in that appending filteredGVs to thirdPartyGroupVersions, but I don't understand why @polvi observed on and off error in the original issue, I expect it to always fail.

@caesarxuchao it's not actually a race. It's actually because of Golang's randomized map iteration "feature" (I think)

So you load in two APIs on the same path, depending the randomness you iterate them in potentially different orders which makes different APIs found (or not).

I will add a test.

Right, the randomness comes from the map here: https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/util/factory.go#L294

@lavalamp test added, ptal.

Thanks

LGTM. Thanks!

@k8s-bot e2e test this please issue: #27920

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

@brendandburns do you want to cherry pick this into the 1.3 branch?

GCE e2e build/test passed for commit 891bd3e.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

I signed it!

CLAs look good, thanks!

@roberthbailey yeah, I'll prepare a cherry pick once this is in.

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit 891bd3e.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue

@brendandburns @pwittrock This is in v1.4 milestone, but with cherrypick tags. Is the intent still to get into 1.3.x at some point?

We're close enough to 1.4 that we can probably wait.

--brendan

From: goltermann notifications@github.com
Sent: Saturday, August 27, 2016 11:24:24 AM
To: kubernetes/kubernetes
Cc: Brendan Burns; Mention
Subject: Re: [kubernetes/kubernetes] Fix a problem with multiple APIs clobbering each other in registration. (#28431)

@brendandburnshttps://github.com/brendandburns @pwittrockhttps://github.com/pwittrock This is in v1.4 milestone, but with cherrypick tags. Is the intent still to get into 1.3.x at some point?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/28431#issuecomment-242932850, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFfDgrOuSFeGSsGsei51sQA1Zv_eKRBPks5qkIDYgaJpZM4JDzsC.

Removing cherrypick tags for now, as this change is already in the 1.4 branch. If the intent is to add it to the 1.3 milestone, please re-add them later.