Add support for kubectl create quota command #28351

sttts · 2016-07-01T12:59:03Z

Follow-up of #19625

Create a resourcequota with the specified name, hard limits and optional scopes

Usage:
  kubectl create quota NAME [--hard=key1=value1,key2=value2] [--scopes=Scope1,Scope2] [--dry-run=bool] [flags]

Aliases:
  quota, q


Examples:
  // Create a new resourcequota named my-quota
  $ kubectl create quota my-quota --hard=cpu=1,memory=1G,pods=2,services=3,replicationcontrollers=2,resourcequotas=1,secrets=5,persistentvolumeclaims=10

  // Create a new resourcequota named best-effort
  $ kubectl create quota best-effort --hard=pods=100 --scopes=BestEffort

googlebot · 2016-07-01T12:59:04Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

derekwaynecarr · 2016-07-02T02:35:30Z

pkg/kubectl/cmd/create_quota.go

@@ -0,0 +1,80 @@
+/*
+Copyright 2015 The Kubernetes Authors All rights reserved.


derekwaynecarr · 2016-07-02T02:37:04Z

Didn't do a deep review but please add support for specifying scopes as well via a flag

sttts · 2016-07-04T07:34:18Z

@derekwaynecarr scopes are coming... only did a quick rebase and some fixes for your old review comments.

sttts · 2016-07-04T09:40:57Z

@derekwaynecarr ptal, scopes are done.

sttts · 2016-07-04T09:42:08Z

@maazkhan can you make the cla bot happy with a short confirmation that you are ok with the commit?

maazkhan · 2016-07-05T07:26:59Z

ok to commit.

derekwaynecarr · 2016-07-07T18:45:15Z

@eparis - what is needed so @sttts is automatically cla:yes ?

sttts · 2016-07-08T06:16:38Z

@derekwaynecarr I usually get automatic cla:yes. It's because I rebased the first commit by @maazkhan.

sttts · 2016-07-13T06:32:38Z

@derekwaynecarr scopes are done. Can you take another look?

derekwaynecarr · 2016-07-21T18:49:48Z

test/e2e/kubectl.go

+			if len(quota.Spec.Hard) != 2 {
+				framework.Failf("Expected two resources, got %v", quota.Spec.Hard)
+			}
+			if r, found := quota.Spec.Hard[api.ResourcePods]; !found || r.MilliValue() != 1000000*1000 {


nit: the check is cleaner to me if we just have a

if expected := resource.MustParse("100000); r, found := ...; !found || r.Cmp(expected) != 0 { ... }

Go only allow one simple statements. We have to write it in two lines:

r, found := quota.Spec.Hard[api.ResourcePods] if expected := resource.MustParse("1000000"); !found || (&r).Cmp(expected) != 0 {

derekwaynecarr · 2016-07-21T18:51:26Z

a couple nits, squash commtis, and then this looks ok to me.

deads2k · 2016-07-26T12:09:41Z

@ncdc Make lawyer-bot happy?

@sttts Mind squashing in the generation. Otherwise we have a commit history where some commits are invalid and that's not much generated code.

sttts · 2016-07-26T12:16:07Z

@deads2k the cla label hopefully is fine with the human-approved override. I have squashed the generated files into the previous patch.

deads2k · 2016-07-26T12:32:36Z

@deads2k the cla label hopefully is fine with the human-approved override. I have squashed the generated files into the previous patch.

Yeah, but I hate chasing them around. It'll be like @Kargakis all over again!

k8s-bot · 2016-07-26T12:47:08Z

GCE e2e build/test passed for commit 199f991.

k8s-github-robot · 2016-07-27T03:35:37Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-07-27T04:20:02Z

GCE e2e build/test passed for commit 199f991.

k8s-github-robot · 2016-07-27T04:20:04Z

Automatic merge from submit-queue

0xmichalis · 2016-08-03T10:35:12Z

Let's hope we will be luckier with the next bot: #27796

sttts added release-note Denotes a PR that will be considered when it comes time to generate release notes. team/ux kind/feature Categorizes issue or PR as related to a new feature. labels Jul 1, 2016

sttts self-assigned this Jul 1, 2016

googlebot added the cla: no label Jul 1, 2016

sttts mentioned this pull request Jul 1, 2016

Add support for kubectl create quota command #19625

Closed

k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 1, 2016

derekwaynecarr reviewed Jul 2, 2016
View reviewed changes

pkg/kubectl/cmd/create_quota.go

@@ -0,0 +1,80 @@

/*

Copyright 2015 The Kubernetes Authors All rights reserved.

Copy link

Member

derekwaynecarr Jul 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix year

sttts changed the title ~~Add support for kubectl create quota command~~ WIP: Add support for kubectl create quota command Jul 4, 2016

sttts changed the title ~~WIP: Add support for kubectl create quota command~~ Add support for kubectl create quota command Jul 4, 2016

k8s-github-robot added kind/old-docs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2016

sttts added the cla: human-approved label Jul 5, 2016

derekwaynecarr assigned derekwaynecarr and deads2k and unassigned sttts Jul 7, 2016

derekwaynecarr removed the cla: no label Jul 7, 2016

derekwaynecarr reviewed Jul 21, 2016
View reviewed changes

derekwaynecarr added this to the v1.4 milestone Jul 21, 2016

googlebot added the cla: no label Jul 26, 2016

sttts and others added 2 commits July 26, 2016 11:32

Fix nsFlag scope in kubectl-run e2e test

36afe2a

Add support for kubectl create quota command

5b95524

sttts force-pushed the sttts-kubectl-create-quota branch 2 times, most recently from 8592b40 to 4397c07 Compare July 26, 2016 11:29

Add --scopes to kubectl-create-quota and add tests

199f991

sttts force-pushed the sttts-kubectl-create-quota branch from 4397c07 to 199f991 Compare July 26, 2016 12:15

deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2016

k8s-github-robot merged commit d82e404 into kubernetes:master Jul 27, 2016

janetkuo mentioned this pull request Sep 14, 2016

Skip kubectl tests (create quota and exit code) on not supported versions #32626

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for kubectl create quota command #28351

Add support for kubectl create quota command #28351

sttts commented Jul 1, 2016 •

edited

Loading

googlebot commented Jul 1, 2016

derekwaynecarr Jul 2, 2016

derekwaynecarr commented Jul 2, 2016

sttts commented Jul 4, 2016

sttts commented Jul 4, 2016

sttts commented Jul 4, 2016

maazkhan commented Jul 5, 2016

derekwaynecarr commented Jul 7, 2016

sttts commented Jul 8, 2016 •

edited

Loading

sttts commented Jul 13, 2016

derekwaynecarr Jul 21, 2016

sttts Jul 26, 2016 •

edited

Loading

derekwaynecarr commented Jul 21, 2016

deads2k commented Jul 26, 2016

sttts commented Jul 26, 2016

deads2k commented Jul 26, 2016

k8s-bot commented Jul 26, 2016

k8s-github-robot commented Jul 27, 2016

k8s-bot commented Jul 27, 2016

k8s-github-robot commented Jul 27, 2016

0xmichalis commented Aug 3, 2016

		@@ -0,0 +1,80 @@
		/*
		Copyright 2015 The Kubernetes Authors All rights reserved.

Add support for kubectl create quota command #28351

Add support for kubectl create quota command #28351

Conversation

sttts commented Jul 1, 2016 • edited Loading

googlebot commented Jul 1, 2016

derekwaynecarr Jul 2, 2016

Choose a reason for hiding this comment

derekwaynecarr commented Jul 2, 2016

sttts commented Jul 4, 2016

sttts commented Jul 4, 2016

sttts commented Jul 4, 2016

maazkhan commented Jul 5, 2016

derekwaynecarr commented Jul 7, 2016

sttts commented Jul 8, 2016 • edited Loading

sttts commented Jul 13, 2016

derekwaynecarr Jul 21, 2016

Choose a reason for hiding this comment

sttts Jul 26, 2016 • edited Loading

Choose a reason for hiding this comment

derekwaynecarr commented Jul 21, 2016

deads2k commented Jul 26, 2016

sttts commented Jul 26, 2016

deads2k commented Jul 26, 2016

k8s-bot commented Jul 26, 2016

k8s-github-robot commented Jul 27, 2016

k8s-bot commented Jul 27, 2016

k8s-github-robot commented Jul 27, 2016

0xmichalis commented Aug 3, 2016

sttts commented Jul 1, 2016 •

edited

Loading

sttts commented Jul 8, 2016 •

edited

Loading

sttts Jul 26, 2016 •

edited

Loading