Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverted the code from 23688 that cause race condition with older version of Go #28319

Merged
merged 1 commit into from
Jul 27, 2016
Merged

reverted the code from 23688 that cause race condition with older version of Go #28319

merged 1 commit into from
Jul 27, 2016

Conversation

grodrigues3
Copy link
Contributor

@grodrigues3 grodrigues3 commented Jun 30, 2016 •
edited
Loading 

* release-note-None

Analytics

@grodrigues3 grodrigues3 changed the title reverted the code from 23688 that cause race condition with older ver… reverted the code from 23688 that cause race condition with older version of Go Jun 30, 2016
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jun 30, 2016
@grodrigues3
Copy link
Contributor Author

@caesarxuchao caesarxuchao added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 26, 2016
@caesarxuchao
Copy link
Member

LGTM. Thank you @grodrigues3!

@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 27, 2016

GCE e2e build/test passed for commit 02e29a9.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit ffff1ab into kubernetes:master Jul 27, 2016
@ncdc
Copy link
Member

ncdc commented Jul 27, 2016

FYI we started hitting the data race again, even with go 1.6.3 (https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/29457/kubernetes-pull-test-unit-integration/36626/)

@eparis eparis mentioned this pull request Aug 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grodrigues3 @caesarxuchao @k8s-bot @k8s-github-robot @ncdc @googlebot