Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federated Services e2e: Simplify logic and logging around verificatio… #28308

Merged
merged 1 commit into from Jun 30, 2016
Merged

Federated Services e2e: Simplify logic and logging around verificatio… #28308

merged 1 commit into from Jun 30, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2016

Simplify logic and logging around verification of underlying services.

Fixes #28269.

Without this PR, service verification in 4 of our e2e tests sometimes fails.

@ghost ghost added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. team/control-plane labels Jun 30, 2016
@ghost ghost added this to the next-candidate milestone Jun 30, 2016
@ghost ghost assigned mml Jun 30, 2016
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jun 30, 2016
@mml
Copy link
Contributor

mml commented Jun 30, 2016

Much better. Thanks.

@mml mml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2016
@mml mml added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 30, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 30, 2016

GCE e2e build/test passed for commit a5599001f2fc77d63d46ded4a2bc3bba970653ea.

@ghost
Copy link
Author

ghost commented Jun 30, 2016

Made one minor improvement to a log message. Re-applying LGTM.

@ghost ghost added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 30, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 30, 2016

GCE e2e build/test passed for commit bc6e626.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 30, 2016

GCE e2e build/test passed for commit bc6e626.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 97736f0 into kubernetes:master Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mml mml

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
next-candidate
Development

Successfully merging this pull request may close these issues.
4 participants
@mml @k8s-bot @k8s-github-robot @googlebot