[kubelet] Allow opting out of automatic cloud provider detection in kubelet. By default kubelet will auto-detect cloud providers #28258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishnu Kannan <vishnuk@google.com> Signed-off-by: Vishnu kannan <vishnuk@google.com>
vishh
added
the
release-note-action-required
|
@dchen1107 Kindly advice if this PR is worth a cherry-pick |
k8s-github-robot
added
the
size/M
|
GCE e2e build/test passed for commit ea789e8. |
|
Thanks @vishh 👍 |
|
This is a behavior regression from 1.2 release, and do break the private cloud user's the cloud configuration without any workaround. We should cherry-pick the fix. Thanks! |
dchen1107
added
the
priority/critical-urgent
|
LGTM |
dchen1107
added
the
lgtm
|
cc/ @erictune |
erictune
added
cherrypick-candidate
cherry-pick-approved
Merged
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit ea789e8. |
|
Automatic merge from submit-queue |
Closed
eparis
pushed a commit
to eparis/kubernetes
that referenced
this pull request
Jun 30, 2016
Automatic merge from submit-queue [kubelet] Allow opting out of automatic cloud provider detection in kubelet. By default kubelet will auto-detect cloud providers fixes kubernetes#28231 (cherry picked from commit ab37fbf)
|
Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28231