Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump skydns godeps to latest #28247

Merged
merged 2 commits into from
Jun 30, 2016

Conversation

girishkalele
Copy link

Update Godeps for github.com/skynetservices/skydns and miekg/dns.

Bump kubedns version to 1.6 with latest skynetservices/skydns code

Built kube-dns for all architectures and pushed containers to gcr.io.

@girishkalele
Copy link
Author

Big ugly Godeps change - first commit only interesting file is Godeps.json.

Second commit bumps the kubedns tag.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jun 29, 2016
@girishkalele
Copy link
Author

@roberthbailey

Background is that we didn't want to pickup latest skydns code before 1.3 - this commit should give us plenty of soak time before 1.4.

@k8s-bot
Copy link

k8s-bot commented Jun 29, 2016

GCE e2e build/test passed for commit 275411e4442dc181000a4a26ebca83b1d43bd575.

@roberthbailey
Copy link
Contributor

This looks like a pretty large change, and I won't have time to review it for a couple of days.

kubernetes.io/cluster-service: "true"
spec:
containers:
- name: kubedns
image: gcr.io/google_containers/kubedns-amd64:1.5
image: gcr.io/google_containers/kubedns-amd64:1.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you built and pushed this yet?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, pushed for all architectures. Tested amd64.

@thockin thockin assigned thockin and unassigned roberthbailey Jun 30, 2016
@thockin
Copy link
Member

thockin commented Jun 30, 2016

LGTM

@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2016
@girishkalele girishkalele added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Jun 30, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 30, 2016

GCE e2e build/test failed for commit 275411e4442dc181000a4a26ebca83b1d43bd575.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

Built kube-dns for all architectures and pushed containers to gcr.io
@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot
Copy link

@girishkalele
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 30, 2016

GCE e2e build/test passed for commit 275411e4442dc181000a4a26ebca83b1d43bd575.

@k8s-bot
Copy link

k8s-bot commented Jun 30, 2016

GCE e2e build/test passed for commit 8614be3.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit c3e9485 into kubernetes:master Jun 30, 2016
@girishkalele girishkalele deleted the skydns_godep_up branch June 30, 2016 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants