Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock all possible kubecfg files at the beginning of ModifyConfig. #28232

Merged
merged 1 commit into from
Jun 30, 2016
Merged

Lock all possible kubecfg files at the beginning of ModifyConfig. #28232

merged 1 commit into from
Jun 30, 2016

Conversation

cjcullen
Copy link
Member

Prevent concurrent calls to ModifyConfig on the same (or overlapping) kubeconfig files.

@cjcullen
Copy link
Member Author

cjcullen commented Jun 29, 2016 •
edited
Loading

@krousey @jlowdermilk @deads2k

New pr addressing @krousey & @deads2k comments. This should be cleaner than #28197.

@cjcullen cjcullen mentioned this pull request Jun 29, 2016
Closed
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jun 29, 2016
@cjcullen cjcullen assigned krousey and deads2k and unassigned smarterclayton Jun 29, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 29, 2016

GCE e2e build/test passed for commit c4e477c8fc128f06701fc2c6a32717015f3a6438.

krousey
krousey reviewed Jun 29, 2016
View reviewed changes
pkg/client/unversioned/clientcmd/config.go
if err = os.MkdirAll(dir, 0755); err != nil {
return err
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I would move this functionality to lockFile.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@cjcullen cjcullen added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jun 29, 2016
@cjcullen
Copy link
Member Author

Addressed comments. PTAL.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 29, 2016
@krousey krousey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 29, 2016

GCE e2e build/test passed for commit 0057627.

@cjcullen cjcullen added this to the next-candidate milestone Jun 30, 2016
This was referenced Jun 30, 2016
Closed
Closed
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 30, 2016

GCE e2e build/test passed for commit 0057627.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit bc9820c into kubernetes:master Jun 30, 2016
@cjcullen cjcullen mentioned this pull request Jun 30, 2016
Closed
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@cjcullen cjcullen modified the milestones: v1.3, next-candidate Jul 2, 2016
@cjcullen cjcullen mentioned this pull request Jul 2, 2016
Merged
@erictune erictune added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 6, 2016
k8s-github-robot pushed a commit that referenced this pull request Jul 13, 2016
Merge pull request #28397 from cjcullen/automated-cherry-pick-of-#282…
137546f 
…32-upstream-release-1.3

Automatic merge from submit-queue

Automated cherry pick of #28232

Cherry pick of #28232 on release-1.3.
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@goltermann goltermann mentioned this pull request Aug 31, 2016
Closed
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#28397 from cjcullen/automated-cherry-pi…
e45a6a3 
…ck-of-#28232-upstream-release-1.3

Automatic merge from submit-queue

Automated cherry pick of kubernetes#28232

Cherry pick of kubernetes#28232 on release-1.3.
@soltysh soltysh mentioned this pull request Jun 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krousey krousey

@deads2k deads2k

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
9 participants
@cjcullen @k8s-bot @k8s-github-robot @k8s-cherrypick-bot @krousey @smarterclayton @googlebot @erictune @deads2k