-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
federation: Upgrading the groupversion to v1beta1 #28186
Conversation
GCE e2e build/test failed for commit 50bbd6cd9a14199965f7ce514affefff6d909b79. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
@caesarxuchao can you review? I didn't see anything obviously wrong but I also didn't look very carefully... |
cc: @davidopp @matchstick This is the PR to achieve what was discussed yesterday w.r.t. correctly reflecting this as beta, not alpha. |
@caesarxuchao This LGTM. Will leave it to you to approve after review. |
The changes look fine. I think you will cherry-pick it to 1.3 branch? You might have problem cherry-picking the clientset changes, because #27293 is not cherry-picked to 1.3. |
Per offline discussion, @nikhiljindal will manually fix the conflicts during cherry-pick. LGTM. |
GCE e2e build/test passed for commit 50bbd6cd9a14199965f7ce514affefff6d909b79. |
GCE e2e build/test passed for commit 7fcf8da. |
GCE e2e build/test passed for commit 7fcf8da. |
Automatic merge from submit-queue |
@eparis is this going to be a pain to cherry pick/rebase? |
The pick was easy, but it doesn't build. Must be some missing pre-req...
|
@nikhiljindal Can you take a look at the build failure, or better yet checkout out release-1.3, check out #28119, apply this commit, and see why it won't build. |
Automatic merge from submit-queue federation: Upgrading the groupversion to v1beta1 This PR contains 2 commits: * Removing fields from Cluster API object that we are not using. This includes: Capacity, Allocatable and ClusterMeta. * Move code and rename groupversion `federation/v1alpha1` to `federation/v1beta1` cc @kubernetes/sig-cluster-federation (cherry picked from commit 044de6e)
Confirmed with @eparis that he was able to cherrypick this PR fine. |
Automatic merge from submit-queue Batch update for 1.3 #28030: Revert "Federation e2e supports aws" #28026: Address outstanding review comments in #27999. #28034: Adding lock files for kubeconfig updating #28004: return nil from NewClientConfig instead of empty struct #28032: Increase pod CPU/memory for fluentd, dns and kube-proxy. #27208: Bump minimum API version for docker to 1.21 #28061: Remove extra double quotes in --federations. #28060: rkt: Fix the 'privileged' check when stage1 annotation is provided. #27996: Image GC logic should compensate for reserved blocks #28044: rkt: Bump required rkt version to 1.9.1. #28040: Tracked addition of federation, sed support in kube DNS #28043: Set grace period to 0 when deleting namespaces after the test. #28002: Fix startup type error in initializeCaches #28087: Hotfix: Fixup the hyperkube dns manifest from a breaking federation PR #28108: Fix initialization of volume controller caches. #28056: Increase kube-dns requirements on CoreOS. #28147: Fix error checks after cloning. #28159: Use : as seccomp security option operator for Docker 1.10 #28165: Refactored, expanded and fixed federated-services e2e tests. #28095: Kubelet should mark VolumeInUse before checking if it is Attached #28172: Build: Add KUBE_GCS_RELEASE_BUCKET_MIRROR option to push-ci-build.sh #28207: Bump cluster autoscaler to 0.2.2 #28160: Volume manager must verify containers terminated before deleting for ungracefully terminated pods #28211: Fix federation e2e tests by correctly managing cluster clients #27944: Fix pvc label selector validation error #28186: federation: Upgrading the groupversion to v1beta1
Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
@nikhiljindal Does this PR require action by the user when upgrading from 1.2.x to 1.3.0? (Think about non-developer users.) If so, please edit your first comment to have a release-note block, like in #28132. If it is just an optional feature, please change the label to just release-note. If it is not a complete feature by itself, then apply "release-note-none" label instead. |
@erictune Changed the label to release-note-none @nikhiljindal and others who might be interested. |
This PR contains 2 commits:
federation/v1alpha1
tofederation/v1beta1
cc @kubernetes/sig-cluster-federation