Add two pd tests with default grace period #28181
Conversation
| @@ -134,6 +135,66 @@ var _ = framework.KubeDescribe("Pod Disks", func() { | |||
| return | |||
| }) | |||
|
|
|||
| It("Same test as above, but remove pod with default grace period 30s [Slow]", func() { | |||
There was a problem hiding this comment.
Can we make this name: "Should schedule a pod w/ a RW PD, gracefully remove it, then schedule it on another host [Slow]"
Can we also on line 78 rename the test to be: ""Should schedule a pod w/ a RW PD, ungracefully remove it, then schedule it on another host [Slow]"
k8s-github-robot
added
size/L
|
GCE e2e build/test passed for commit e9d5335d94f139a99a8180a33fd10389f064b9d5. |
Add two tests in pd.go. They are same as the flaky test, but the pod deletion has default grace period
matchstick
added
the
lgtm
k8s-github-robot
removed
the
lgtm
matchstick
added
lgtm
|
GCE e2e build/test passed for commit e94242e. |
matchstick
added
the
priority/important-soon
|
I added this to the 1.3 milestone as it is related to 1.3 but does not need to be cherry picked for 1.3. So I am removing the milestone addition now. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit e94242e. |
|
Automatic merge from submit-queue |
| @@ -75,7 +75,7 @@ var _ = framework.KubeDescribe("Pod Disks", func() { | |||
| }) | |||
|
|
|||
| // Flaky-- Issue #27691 | |||
| It("[Flaky] should schedule a pod w/ a RW PD, remove it, then schedule it on another host [Slow]", func() { | |||
| It("[Flaky] should schedule a pod w/ a RW PD, ungracefully remove it, then schedule it on another host [Slow]", func() { | |||
There was a problem hiding this comment.
I guess it's too late to comment on this pr, but I'm curious to know what you think. It seems that the defer below should be moved to after the call to podClient.Create(). If the Create() fails then the not-yet-created pod will be try to be deleted, and the not-yet-attached disks will try to be detached. This is probably very minor, or perhaps I'm missing something?
…ck-of-#28048-kubernetes#28090-kubernetes#28181-kubernetes#28404-kubernetes#29031-upstream-release-1.3 Automated cherry pick of kubernetes#28048 kubernetes#28090 kubernetes#28181 kubernetes#28404 kubernetes#29031 upstream release 1.3
Add two tests in pd.go. They are same as the flaky test, but the pod deletion has default grace period