Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare out of disk when there is no free inodes #28176

Merged
merged 1 commit into from
Jul 2, 2016
Merged

Declare out of disk when there is no free inodes #28176

merged 1 commit into from
Jul 2, 2016
+102 −44

Conversation

ronnielai
Copy link
Contributor

@ronnielai ronnielai commented Jun 28, 2016 •
edited
Loading

@ronnielai ronnielai added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 28, 2016
@ronnielai ronnielai added this to the v1.4 milestone Jun 28, 2016
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 28, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 28, 2016

GCE e2e build/test passed for commit 2fb2ef196ef9e7d0c0ec20d35e7dfa60d2234322.

@k8s-bot
Copy link

k8s-bot commented Jun 30, 2016

GCE e2e build/test passed for commit 8cc6057.

vishh
vishh reviewed Jul 1, 2016
View reviewed changes
pkg/kubelet/disk_manager.go
if fsInfo.Available < int64(threshold)*mb {
glog.Infof("Running out of space on disk for %q: available %d MB, threshold %d MB", fsType, fsInfo.Available/mb, threshold)
return false, nil
}
if fsInfo.InodesFree == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we define a threshold for inodes as well that is > 0? By the time kubelet detects that there are inodes, the pods on the node are most likely stuck.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment can be resolved in a subsequent PR too.

@vishh
Copy link
Contributor

vishh commented Jul 1, 2016

Just one comment. Otherwise LGTM

@vishh vishh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@derekwaynecarr
Copy link
Member

This is a distinct condition from DiskPressure, correct?

#27199

(Which since I have been out appears to need a rebase next week)

@k8s-bot
Copy link

k8s-bot commented Jul 2, 2016

GCE e2e build/test passed for commit 8cc6057.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 40b8fb4 into kubernetes:master Jul 2, 2016
@derekwaynecarr derekwaynecarr mentioned this pull request Jul 6, 2016
Closed
@ronnielai ronnielai mentioned this pull request Jul 6, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 7, 2016
Merge pull request #28536 from kubernetes/revert-28176-inode-check-dep
52e8d4f 
Automatic merge from submit-queue

Revert "Declare out of disk when there is no free inodes"

Reverts #28176

Fixes #28481
@ojongerius ojongerius mentioned this pull request Mar 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vishh vishh

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@ronnielai @k8s-bot @vishh @k8s-github-robot @derekwaynecarr @googlebot