Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Add KUBE_GCS_RELEASE_BUCKET_MIRROR option to push-ci-build.sh #28172

Merged
merged 1 commit into from
Jun 28, 2016
Merged

Build: Add KUBE_GCS_RELEASE_BUCKET_MIRROR option to push-ci-build.sh #28172

merged 1 commit into from
Jun 28, 2016
+25 −2

Conversation

zmerlynn
Copy link
Member

And start pushing to new CI bucket as well.

(This will need a cherrypick back to release-1.3 before I can do any bucket surgery, FWIW.)

Analytics

@zmerlynn
Copy link
Member Author

See https://groups.google.com/d/msg/kubernetes-dev/2_71FD_gScM/bSzMZfWVCAAJ for context (and an internal thread).

cc @kubernetes/test-infra-maintainers

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jun 28, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 28, 2016

GCE e2e build/test passed for commit c36c326ea8118e402f7ce39d454d59e4b98fb064.

@zmerlynn zmerlynn added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherrypick-candidate and removed release-note-label-needed labels Jun 28, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@ixdy
Copy link
Member

ixdy commented Jun 28, 2016

cc @kubernetes/release-maintainers

@zmerlynn zmerlynn added this to the v1.3 milestone Jun 28, 2016
@roberthbailey
Copy link
Contributor

lgtm

ixdy
ixdy reviewed Jun 28, 2016
View reviewed changes
build/common.sh
if [[ -n "${KUBE_GCS_RELEASE_BUCKET_MIRROR:-}" ]]; then
local -r gcs_mirror="gs://${KUBE_GCS_RELEASE_BUCKET_MIRROR}/${KUBE_GCS_RELEASE_PREFIX}"
kube::log::status "Mirroring build to ${gcs_mirror}"
gsutil -q -m "${gcs_options[@]+${gcs_options[@]}}" rsync -d -r "${gcs_destination}" "${gcs_mirror}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add || return 1 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. :)

@zmerlynn
Copy link
Member Author

PTAL

@k8s-bot
Copy link

k8s-bot commented Jun 28, 2016

GCE e2e build/test passed for commit 4282748.

@ixdy
Copy link
Member

ixdy commented Jun 28, 2016

LGTM

@ixdy ixdy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2016
@zmerlynn
Copy link
Member Author

@k8s-oncall: Requesting manual merge so I can babysit kubernetes-build job during business hours.

@j3ffml j3ffml merged commit 43437e4 into kubernetes:master Jun 28, 2016
zmerlynn added a commit to zmerlynn/kubernetes that referenced this pull request Jun 28, 2016
@zmerlynn
Change references to gs://kubernetes-release/ci
9248532 
Change over to gs://kubernetes-release-dev/ci. This should be all the
places we reference gs://kubernetes-release/ci or
https://storage.googleapis.com/kubernetes-release/ci. I'm happy to be
wrong.

Follow-on to kubernetes#28172
@zmerlynn zmerlynn mentioned this pull request Jun 28, 2016
Merged
@zmerlynn zmerlynn deleted the push-alt-ci branch June 28, 2016 23:49
k8s-github-robot pushed a commit that referenced this pull request Jun 29, 2016
Merge pull request #28193 from zmerlynn/pull-ci-elsewhere
d965b47 
Automatic merge from submit-queue

Change references to gs://kubernetes-release/ci

Change over to gs://kubernetes-release-dev/ci. This should be all the
places we reference gs://kubernetes-release/ci or
https://storage.googleapis.com/kubernetes-release/ci. I'm happy to be
wrong.

Follow-on to #28172

[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()
@zmerlynn zmerlynn mentioned this pull request Jun 29, 2016
Merged
eparis pushed a commit to eparis/kubernetes that referenced this pull request Jun 29, 2016
@j3ffml @eparis
Merge pull request kubernetes#28172 from zmerlynn/push-alt-ci
1fea4b3 
Build: Add KUBE_GCS_RELEASE_BUCKET_MIRROR option to push-ci-build.sh
(cherry picked from commit 43437e4)
@eparis eparis mentioned this pull request Jun 29, 2016
Merged
@zmerlynn zmerlynn mentioned this pull request Jun 29, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 29, 2016
Merge pull request #28233 from zmerlynn/revert-revert-28172
3d22132 
Automatic merge from submit-queue

Revert revert of #28172

We're going to try reintroducing just the build changes in #28172, get signal off of that, and wait on re-introducing #28193. I also setup the `gke-updown` job for faster signal: kubernetes/test-infra#239.

This reverts commit fe64293.

[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()
k8s-github-robot pushed a commit that referenced this pull request Jun 29, 2016
Merge pull request #28119 from eparis/release-1.3
28925df 
Automatic merge from submit-queue

Batch update for 1.3

#28030: Revert "Federation e2e supports aws"
#28026: Address outstanding review comments in #27999.
#28034: Adding lock files for kubeconfig updating
#28004: return nil from NewClientConfig instead of empty struct
#28032: Increase pod CPU/memory for fluentd, dns and kube-proxy.
#27208: Bump minimum API version for docker to 1.21
#28061: Remove extra double quotes in --federations.
#28060: rkt: Fix the 'privileged' check when stage1 annotation is provided.
#27996: Image GC logic should compensate for reserved blocks
#28044: rkt: Bump required rkt version to 1.9.1.
#28040: Tracked addition of federation, sed support in kube DNS
#28043: Set grace period to 0 when deleting namespaces after the test.
#28002: Fix startup type error in initializeCaches
#28087: Hotfix: Fixup the hyperkube dns manifest from a breaking federation PR
#28108: Fix initialization of volume controller caches.
#28056: Increase kube-dns requirements on CoreOS.
#28147: Fix error checks after cloning.
#28159: Use : as seccomp security option operator for Docker 1.10
#28165: Refactored, expanded and fixed federated-services e2e tests.
#28095: Kubelet should mark VolumeInUse before checking if it is Attached
#28172: Build: Add KUBE_GCS_RELEASE_BUCKET_MIRROR option to push-ci-build.sh
#28207: Bump cluster autoscaler to 0.2.2
#28160: Volume manager must verify containers terminated before deleting for ungracefully terminated pods
#28211: Fix federation e2e tests by correctly managing cluster clients
#27944: Fix pvc label selector validation error
#28186: federation: Upgrading the groupversion to v1beta1
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

zmerlynn added a commit to zmerlynn/kubernetes that referenced this pull request Jul 11, 2016
@zmerlynn
Change references to gs://kubernetes-release/ci
6f2df5c 
Change over to gs://kubernetes-release-dev/ci. This should be all the
places we reference gs://kubernetes-release/ci or
https://storage.googleapis.com/kubernetes-release/ci. I'm happy to be
wrong.

Follow-on to kubernetes#28172
@zmerlynn zmerlynn mentioned this pull request Jul 11, 2016
Merged
@zmerlynn zmerlynn modified the milestones: v1.1, v1.3 Jul 11, 2016
zmerlynn added a commit to zmerlynn/kubernetes that referenced this pull request Jul 11, 2016
@zmerlynn
Change references to gs://kubernetes-release/ci
5759213 
Change over to gs://kubernetes-release-dev/ci. This should be all the
places we reference gs://kubernetes-release/ci or
https://storage.googleapis.com/kubernetes-release/ci. I'm happy to be
wrong.

Follow-on to kubernetes#28172
@zmerlynn zmerlynn mentioned this pull request Jul 11, 2016
Merged
zmerlynn added a commit that referenced this pull request Jul 12, 2016
@zmerlynn
Merge pull request #28782 from zmerlynn/automated-cherry-pick-of-#28172-
ed309e6 
#28193-upstream-release-1.2

Automated cherry pick of #28172 #28193
zmerlynn added a commit to zmerlynn/kubernetes that referenced this pull request Jul 12, 2016
@zmerlynn
Change references to gs://kubernetes-release/ci
df21a86 
Change over to gs://kubernetes-release-dev/ci. This should be all the
places we reference gs://kubernetes-release/ci or
https://storage.googleapis.com/kubernetes-release/ci. I'm happy to be
wrong.

Follow-on to kubernetes#28172
This was referenced Jul 12, 2016
Closed
Merged
@roberthbailey roberthbailey added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 14, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@zmerlynn
Change references to gs://kubernetes-release/ci
f51c9fa 
Change over to gs://kubernetes-release-dev/ci. This should be all the
places we reference gs://kubernetes-release/ci or
https://storage.googleapis.com/kubernetes-release/ci. I'm happy to be
wrong.

Follow-on to kubernetes#28172
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@zmerlynn
Change references to gs://kubernetes-release/ci
7451387 
Change over to gs://kubernetes-release-dev/ci. This should be all the
places we reference gs://kubernetes-release/ci or
https://storage.googleapis.com/kubernetes-release/ci. I'm happy to be
wrong.

Follow-on to kubernetes#28172
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@zmerlynn
Merge pull request kubernetes#28782 from zmerlynn/automated-cherry-pi…
47964c0 
…ck-of-#28172-kubernetes#28193-upstream-release-1.2

Automated cherry pick of kubernetes#28172 kubernetes#28193
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
@zmerlynn
Change references to gs://kubernetes-release/ci
8e1eb3f 
Change over to gs://kubernetes-release-dev/ci. This should be all the
places we reference gs://kubernetes-release/ci or
https://storage.googleapis.com/kubernetes-release/ci. I'm happy to be
wrong.

Follow-on to kubernetes#28172
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@zmerlynn
Change references to gs://kubernetes-release/ci
58a41b8 
Change over to gs://kubernetes-release-dev/ci. This should be all the
places we reference gs://kubernetes-release/ci or
https://storage.googleapis.com/kubernetes-release/ci. I'm happy to be
wrong.

Follow-on to kubernetes#28172
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@zmerlynn
Merge pull request kubernetes#28782 from zmerlynn/automated-cherry-pi…
99aeb9b 
…ck-of-#28172-kubernetes#28193-upstream-release-1.2

Automated cherry pick of kubernetes#28172 kubernetes#28193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ixdy ixdy

Labels
area/build-release cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
9 participants
@zmerlynn @k8s-bot @k8s-cherrypick-bot @ixdy @roberthbailey @j3ffml @googlebot @erictune @k8s-github-robot