Fixed goroutinemap race on Wait() #28153
Merged
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync.WaitGroup produces data races when a GoroutineMap is empty and Wait() and Run() are called at the same time. From sync.WaitGroup: Note that calls with a positive delta that occur when the counter is zero must happen before a Wait. Fixes kubernetes#28128
jsafrane
added
team/cluster
release-note-none
k8s-github-robot
added
the
size/S
|
GCE e2e build/test passed for commit 06082b1. |
saad-ali
added
the
lgtm
|
LGTM |
|
Is something wrong with my CLA? I hope I still work here at Red Hat. Or should I worry? :-) |
|
Heh, immediately after my comment the CLA got green. |
|
GCE e2e build/test passed for commit 06082b1. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 06082b1. |
|
Automatic merge from submit-queue |
This was referenced Jul 19, 2016
This was referenced Aug 1, 2016
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ck-of-#28153-kubernetes#28409-kubernetes#28939-upstream-release-1.3 Automated cherry pick of kubernetes#28153 kubernetes#28409 kubernetes#28939 upstream release 1.3
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…ck-of-#28153-kubernetes#28409-kubernetes#28939-upstream-release-1.3 Automated cherry pick of kubernetes#28153 kubernetes#28409 kubernetes#28939 upstream release 1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync.WaitGroup produces data races when a GoroutineMap is empty and Wait() and Run() are called at the same time.
From sync.WaitGroup:
Fixes #28128
Note that this issue affects only PersistentVolume unit tests.
@saad-ali, PTAL