Fix initialization of volume controller caches. #28108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PersistentVolumeController.initializeCaches() to pass pointers to volume or claim to storeObjectUpdate() and add extra functions to enforce that the right types are checked in the future. Fixes kubernetes#28076
jsafrane
added
release-note-none
|
This should be cherry picked together with #28002 |
jsafrane
added
the
priority/critical-urgent
|
Removing label |
k8s-github-robot
added
the
size/M
|
GCE e2e build/test passed for commit a8dfe7fde96fe0dc6fb2c87b49e124fe005cdbb5. |
|
GCE e2e build/test passed for commit 169076e. |
| storeObjectUpdate(ctrl.volumes.store, volume, "volume") | ||
| clone, err := conversion.NewCloner().DeepCopy(&volume) | ||
| if err != nil { | ||
| glog.Errorf("error cloning volume %q: %v", volume.Name, err) |
There was a problem hiding this comment.
If you get this error, you continue to use clone right below?
|
The added type checking makes me feel a LOT better about this code, thanks. |
|
Umm this is effecting nearly every PR atm. |
|
Anything we can do to accelerate this? PV controller unit test flake (#28076) is dominating cause of submit queue blockage. |
|
I'm ok with merging now and fixing my comments in a follow-up if this is blocking merges. |
|
Yeah, the issue this (hopefully) fixes is blocking merges and causing pr builder flakes. |
|
LGTM |
lavalamp
added
lgtm
|
Automatic merge from submit-queue |
erictune
added
the
cherry-pick-approved
jsafrane
added a commit
to jsafrane/kubernetes
that referenced
this pull request
Jun 28, 2016
We should not use clone result When cloning fails. Fixes issues found in kubernetes#28108.
|
Thanks for review, I filled #28108 with fixed error checks. |
Merged
k8s-github-robot
pushed a commit
that referenced
this pull request
Jun 28, 2016
Automatic merge from submit-queue Fix error checks after cloning. We should not use clone result When cloning fails. Fixes issues found in #28108.
eparis
pushed a commit
to eparis/kubernetes
that referenced
this pull request
Jun 29, 2016
Automatic merge from submit-queue Fix initialization of volume controller caches. Fix `PersistentVolumeController.initializeCaches()` to pass pointers to volume or claim to `storeObjectUpdate()` and add extra functions to enforce that the right types are checked in the future. Fixes kubernetes#28076 (cherry picked from commit be68214)
eparis
pushed a commit
to eparis/kubernetes
that referenced
this pull request
Jun 29, 2016
Automatic merge from submit-queue Fix error checks after cloning. We should not use clone result When cloning fails. Fixes issues found in kubernetes#28108. (cherry picked from commit 8c5be72)
k8s-github-robot
pushed a commit
that referenced
this pull request
Jun 29, 2016
Automatic merge from submit-queue Batch update for 1.3 #28030: Revert "Federation e2e supports aws" #28026: Address outstanding review comments in #27999. #28034: Adding lock files for kubeconfig updating #28004: return nil from NewClientConfig instead of empty struct #28032: Increase pod CPU/memory for fluentd, dns and kube-proxy. #27208: Bump minimum API version for docker to 1.21 #28061: Remove extra double quotes in --federations. #28060: rkt: Fix the 'privileged' check when stage1 annotation is provided. #27996: Image GC logic should compensate for reserved blocks #28044: rkt: Bump required rkt version to 1.9.1. #28040: Tracked addition of federation, sed support in kube DNS #28043: Set grace period to 0 when deleting namespaces after the test. #28002: Fix startup type error in initializeCaches #28087: Hotfix: Fixup the hyperkube dns manifest from a breaking federation PR #28108: Fix initialization of volume controller caches. #28056: Increase kube-dns requirements on CoreOS. #28147: Fix error checks after cloning. #28159: Use : as seccomp security option operator for Docker 1.10 #28165: Refactored, expanded and fixed federated-services e2e tests. #28095: Kubelet should mark VolumeInUse before checking if it is Attached #28172: Build: Add KUBE_GCS_RELEASE_BUCKET_MIRROR option to push-ci-build.sh #28207: Bump cluster autoscaler to 0.2.2 #28160: Volume manager must verify containers terminated before deleting for ungracefully terminated pods #28211: Fix federation e2e tests by correctly managing cluster clients #27944: Fix pvc label selector validation error #28186: federation: Upgrading the groupversion to v1beta1
|
Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
PersistentVolumeController.initializeCaches()to pass pointers to volume or claim tostoreObjectUpdate()and add extra functions to enforce that the right types are checked in the future.Fixes #28076