Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #27509 #28053

Conversation

j3ffml
Copy link
Contributor

@j3ffml j3ffml commented Jun 24, 2016

Cherry pick of #27509 on release-1.2.

@j3ffml j3ffml modified the milestone: v1.2 Jun 24, 2016
@j3ffml
Copy link
Contributor Author

j3ffml commented Jun 24, 2016

cc @roberthbailey

@roberthbailey roberthbailey added this to the v1.2 milestone Jun 24, 2016
@j3ffml j3ffml force-pushed the automated-cherry-pick-of-#27509-upstream-release-1.2 branch from bec8d8e to 4881a1e Compare June 24, 2016 22:08
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2016
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@j3ffml j3ffml added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 24, 2016
@roberthbailey roberthbailey added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 24, 2016
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 24, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 24, 2016

GCE e2e build/test failed for commit bec8d8ed61157a33203b22f538433d412c723475.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-bot
Copy link

k8s-bot commented Jun 24, 2016

GCE e2e build/test failed for commit 4881a1e.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@j3ffml
Copy link
Contributor Author

j3ffml commented Jun 24, 2016

PR builder is failing on


• Failure [63.083 seconds]
Kubectl client
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:1200
  Simple pod
  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:526
    should support exec through an HTTP proxy [It]
    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:456

    Jun 24 15:20:53.540: Can't build static kubectl due to missing hack/build-go.sh. Error=stat /var/lib/jenkins/workspace/kubernetes-pull-build-test-e2e-gce/kubernetes/hack/build-go.sh: no such file or directory

    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:256

I'm not sure how this works for head, but this cherrypick doesn't affect that test, and it's passing on the continuous build. cc @spxtr

@roberthbailey roberthbailey removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 24, 2016
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 24, 2016
@k8s-github-robot
Copy link

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@eparis eparis added cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 24, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 24, 2016

GCE e2e build/test failed for commit 4881a1e.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@eparis eparis removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2016
@eparis
Copy link
Contributor

eparis commented Jun 24, 2016

@roberthbailey The bot is really angry on 1.2 these days. Adding LGTM is going to make it comment like wild. You are going to have to 1.2 by hand.

@roberthbailey roberthbailey merged commit ca620f9 into kubernetes:release-1.2 Jun 24, 2016
@roberthbailey
Copy link
Contributor

I'll revert if our post-submit 1.2 tests start failing.

@roberthbailey roberthbailey added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 24, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@k8s-bot
Copy link

k8s-bot commented Jun 24, 2016

GCE e2e build/test failed for commit 4881a1e.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@roberthbailey
Copy link
Contributor

wow, it took the label off of the cherry pick PR instead of the original PR.

@k8s-bot
Copy link

k8s-bot commented Jun 24, 2016

GCE e2e build/test failed for commit 4881a1e.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@j3ffml j3ffml deleted the automated-cherry-pick-of-#27509-upstream-release-1.2 branch October 19, 2016 22:17
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…-pick-of-#27509-upstream-release-1.2

Automated cherry pick of kubernetes#27509
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…-pick-of-#27509-upstream-release-1.2

Automated cherry pick of kubernetes#27509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants