federation service controller: fixing the logic to update DNS records #27999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
priority/important-soon
k8s-github-robot
added
size/M
ghost
mentioned this pull request
|
GCE e2e build/test passed for commit 6b435a6. |
| glog.V(4).Infof("There are no healthy endpoint addresses at level %q, so CNAME to %q, if provided", dnsName, uplevelCname) | ||
| if uplevelCname != "" { | ||
| glog.V(4).Infof("Creating CNAME to %q for %q", uplevelCname, dnsName) | ||
| newRrset := rrsets.New(dnsName, []string{uplevelCname}, minDnsTtl, rrstype.CNAME) | ||
| rrset, err = rrsets.Add(newRrset) |
There was a problem hiding this comment.
Add glog.V(4).Infof("Adding recordset %v", newRrset) as you do in the else block.
|
Thanks for adding the logs. They are going to be super useful. Adding LGTM. You can reply to comments/ resolve them in follow up PR. |
nikhiljindal
added
lgtm
k8s-github-robot
removed
the
lgtm
nikhiljindal
changed the title
nikhiljindal
added
release-note
|
Fixed release note label and title |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 6b435a6. |
|
Automatic merge from submit-queue |
ghost
mentioned this pull request
k8s-github-robot
pushed a commit
that referenced
this pull request
Jun 24, 2016
…ns-deletion-logic-fix Automatic merge from submit-queue Address outstanding review comments in #27999.
Merged
eparis
pushed a commit
to eparis/kubernetes
that referenced
this pull request
Jun 29, 2016
…-nits-in-dns-deletion-logic-fix Automatic merge from submit-queue Address outstanding review comments in kubernetes#27999. (cherry picked from commit 9b215a3)
k8s-github-robot
pushed a commit
that referenced
this pull request
Jun 29, 2016
Automatic merge from submit-queue Batch update for 1.3 #28030: Revert "Federation e2e supports aws" #28026: Address outstanding review comments in #27999. #28034: Adding lock files for kubeconfig updating #28004: return nil from NewClientConfig instead of empty struct #28032: Increase pod CPU/memory for fluentd, dns and kube-proxy. #27208: Bump minimum API version for docker to 1.21 #28061: Remove extra double quotes in --federations. #28060: rkt: Fix the 'privileged' check when stage1 annotation is provided. #27996: Image GC logic should compensate for reserved blocks #28044: rkt: Bump required rkt version to 1.9.1. #28040: Tracked addition of federation, sed support in kube DNS #28043: Set grace period to 0 when deleting namespaces after the test. #28002: Fix startup type error in initializeCaches #28087: Hotfix: Fixup the hyperkube dns manifest from a breaking federation PR #28108: Fix initialization of volume controller caches. #28056: Increase kube-dns requirements on CoreOS. #28147: Fix error checks after cloning. #28159: Use : as seccomp security option operator for Docker 1.10 #28165: Refactored, expanded and fixed federated-services e2e tests. #28095: Kubelet should mark VolumeInUse before checking if it is Attached #28172: Build: Add KUBE_GCS_RELEASE_BUCKET_MIRROR option to push-ci-build.sh #28207: Bump cluster autoscaler to 0.2.2 #28160: Volume manager must verify containers terminated before deleting for ungracefully terminated pods #28211: Fix federation e2e tests by correctly managing cluster clients #27944: Fix pvc label selector validation error #28186: federation: Upgrading the groupversion to v1beta1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dd78dd8 introduced an 'endpointsReachable' boolean argument to ensureDnsRrrsets(), which is incorrect.
The logic prior to the above commit does the right thing, provided that the correct set of healthy endpoints are passed into that function.
This PR essentially reverts the part of the above commit related to 'endpointsReachable', and adds some debug logging (at --v=4) in case it becomes necessary.
cc: @mfanjie @mml @nikhiljindal @madhusudancs