Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Copy and display source location prominently on Kubernetes instances" #27924

Merged
merged 1 commit into from
Jun 23, 2016
Merged

Revert "Copy and display source location prominently on Kubernetes instances" #27924

merged 1 commit into from
Jun 23, 2016

Conversation

gmarek
Copy link
Contributor

@gmarek gmarek commented Jun 23, 2016 •
edited
Loading

Reverts #27840

This broke cluster upgrade, ref #27764 (comment). cc @janetkuo @zmerlynn

@gmarek gmarek added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 23, 2016
@gmarek gmarek added this to the v1.3 milestone Jun 23, 2016
@gmarek gmarek added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 23, 2016
@piosz
Copy link
Member

piosz commented Jun 23, 2016

LGTM

@piosz piosz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2016
@wojtek-t
Copy link
Member

@davidopp

@wojtek-t
Copy link
Member

LGTM

@piosz
Copy link
Member

piosz commented Jun 23, 2016 •
edited by gmarek
Loading

@zmerlynn before re-adding this please make sure that cluster/gce/upgrade.sh works for the master.

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 23, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 23, 2016

GCE e2e build/test passed for commit 56d4586.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 23, 2016

GCE e2e build/test passed for commit 56d4586.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 11fdfb5 into master Jun 23, 2016
@piosz piosz deleted the revert-27840-add-sources-to-node branch June 23, 2016 09:49
@wojtek-t wojtek-t mentioned this pull request Jun 23, 2016
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wojtek-t wojtek-t

@piosz piosz

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@gmarek @piosz @wojtek-t @k8s-bot @k8s-github-robot @googlebot