Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch the case where we cannot find any nodes. #27891

Merged
merged 1 commit into from
Jun 22, 2016
Merged

Catch the case where we cannot find any nodes. #27891

merged 1 commit into from
Jun 22, 2016

Conversation

mml
Copy link
Contributor

@mml mml commented Jun 22, 2016

It's possible to fall through the loops above with node still nil. This
catches this and reports an error.

Found this working on #27819.

@mml
Catch the case where we cannot find any nodes.
d6ab379 
It's possible to fall through the loops above with node still nil.  This
catches this and reports an error.

Found this working on kubernetes#27819.
@mml mml added this to the v1.3 milestone Jun 22, 2016
@mml mml added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. retest-not-required release-note-none Denotes a PR that doesn't merit a release note. labels Jun 22, 2016
@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2016
@madhusudancs
Copy link
Contributor

LGTM! Thanks.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 22, 2016

GCE e2e build/test passed for commit d6ab379.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit db43b68 into kubernetes:master Jun 22, 2016
@nikhiljindal nikhiljindal mentioned this pull request Jun 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@madhusudancs madhusudancs

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@mml @madhusudancs @k8s-bot @k8s-github-robot @googlebot