Modifying the default container GC policy parameters #27881
Conversation
ronnielai
commented
Jun 22, 2016
•
ronnielai
commented
- Marked container GC policy to be deprecated in the future
- Changed the default values for container GC policy per the eviction proposal
ronnielai
added
the
release-note
k8s-github-robot
added
the
size/XS
ronnielai
changed the title
ronnielai
changed the title
| @@ -189,8 +189,11 @@ func (s *KubeletServer) AddFlags(fs *pflag.FlagSet) { | |||
| fs.BoolVar(&s.RunOnce, "runonce", s.RunOnce, "If true, exit after spawning pods from local manifests or remote urls. Exclusive with --api-servers, and --enable-server") | |||
| fs.BoolVar(&s.EnableDebuggingHandlers, "enable-debugging-handlers", s.EnableDebuggingHandlers, "Enables server endpoints for log collection and local running of containers and commands") | |||
| fs.DurationVar(&s.MinimumGCAge.Duration, "minimum-container-ttl-duration", s.MinimumGCAge.Duration, "Minimum age for a finished container before it is garbage collected. Examples: '300ms', '10s' or '2h45m'") | |||
| fs.MarkDeprecated("minimum-container-ttl-duration", "will be removed in a future version") | |||
There was a problem hiding this comment.
nit: Mention what flags users have to use instead here and below
There was a problem hiding this comment.
The eviction proposal deprecates these 3 flags without introducing any new flags for replacement. Do you mean the eviction-related flags should be mentioned here?
There was a problem hiding this comment.
Yeah. The eviction flags should be suggested as alternatives.
On Wed, Jun 22, 2016 at 11:38 AM, ronnielai notifications@github.com
wrote:
In cmd/kubelet/app/options/options.go
#27881 (comment)
:@@ -189,8 +189,11 @@ func (s *KubeletServer) AddFlags(fs *pflag.FlagSet) {
fs.BoolVar(&s.RunOnce, "runonce", s.RunOnce, "If true, exit after spawning pods from local manifests or remote urls. Exclusive with --api-servers, and --enable-server")
fs.BoolVar(&s.EnableDebuggingHandlers, "enable-debugging-handlers", s.EnableDebuggingHandlers, "Enables server endpoints for log collection and local running of containers and commands")
fs.DurationVar(&s.MinimumGCAge.Duration, "minimum-container-ttl-duration", s.MinimumGCAge.Duration, "Minimum age for a finished container before it is garbage collected. Examples: '300ms', '10s' or '2h45m'")
- fs.MarkDeprecated("minimum-container-ttl-duration", "will be removed in a future version")
The eviction proposal
https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/kubelet-eviction.md#deprecation-of-existing-features
deprecates these 3 flags without introducing any new flags for replacement.
Do you mean the eviction-related flags should be mentioned here?—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/pull/27881/files/31c2c066f8680dfcb41b7d0223066c544188a87d#r68110138,
or mute the thread
https://github.com/notifications/unsubscribe/AGvIKH3lYyE48XbhBNGCRPihEtVy84lQks5qOYESgaJpZM4I8AQH
.
There was a problem hiding this comment.
Thx. I've updated. PTAL.
|
GCE e2e build/test passed for commit 095e04d. |
vishh
added
the
lgtm
|
Given that we are only deprecating these flags and not removing them, we should keep the gc functionality around until these flags can be removed. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
@k8s-bot test this issue: #IGNORE Tests have been pending for 24 hours |
|
GCE e2e build/test passed for commit 095e04d. |
|
Automatic merge from submit-queue |
|
GCE e2e build/test passed for commit 095e04d. |
