cc @quinton-hoole

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@lukaszo I'm not sure that this is such a good idea. If, during this step of the test, we fail to detect one of the zones, and then later we spread pods across that zone, the test will fail for mysterious reasons. Let me think about this a bit.

Could you explain to me in a bit more detail what you're trying to achieve with this change (other than silently masking a failure, which is generally a bad thing).

@quinton-hoole I'm running e2e tests locally using export KUBERNETES_PROVIDER=vagrant and cluster/kube-up.sh to start a cluster. Ubernetes Lite tests are failing because my nodes do not have a failure-domain.beta.kubernetes.io/zone label.
This label is added in kubelet by cloud provider. In my case there is no provider and label is not added.

In my patch before continue I may log the error message. What do you think?

@lukaszo These tests are intended to be completely skipped if you have less than 2 zones in your cluster, or if you're not on GKE, GCE or AWS:

        framework.SkipUnlessAtLeast(zoneCount, 2, "Zone count is %d, only run for multi-zone clusters, skipping test")              framework.SkipUnlessAtLeast(zoneCount, 2, "Zone count is %d, only run for multi-zone clusters, skipping test")
        framework.SkipUnlessProviderIs("gce", "gke", "aws")

I think that you should be able to fix your problem by simply changing the order of the above two lines.

I think that's the best fix.

An alternative would be to make sure that 'getZoneCount()' returns 1 if no labels can be found.

If you send me a good PR for either of the above, I'll approve it.

@quinton-hoole I've chosen the first option :)
it has to be before getZoneCount which is failing

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

ok to test

GCE e2e build/test passed for commit 58062a2.

• Build Log
• Test Artifacts
• Internal Jenkins Results

GCE e2e build/test passed for commit 58062a2.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

@k8s-bot unit test this issue: #28076

@fejta can you restart GKE e2e tests? Looks like a random failure: AccessDeniedException: 403 Forbidden

@spxtr @ixdy

The GKE X should be ignored.

Sorry, please ignore the Jenkins GKE e2e test, note that Jenkins GKE smoke e2e below it passes. The submit queue won't check it before merging.

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit 58062a2.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue