New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual cherry pick of #27829 on release-1.2 #27865

Merged

roberthbailey merged 1 commit into kubernetes:release-1.2 from zmerlynn:manual-cherrypick-25178

Jun 22, 2016

Member

zmerlynn commented Jun 22, 2016 •

edited by roberthbailey

Loading

GCE provider: Create TargetPool with 200 instances, then update with rest

Cherry pick of #27829 on release-1.2, manually. It was messy enough just cherrypicking a single commit that grabbing of #27829 or the combo of #25178/#27829 was just a waste of time.


          GCE provider: Create TargetPool with 200 instances, then update with …

d930865

…rest

Tested with 2000 nodes, this actually meets the GCE API specifications
(which is nutty). Previous PR (kubernetes#25178) was based on a mistaken
understanding of a poorly documented set of limitations, and even
poorer testing, for which I am embarassed.

zmerlynn added the cherry-pick-approved label

zmerlynn assigned roberthbailey and wojtek-t

googlebot added the cla: yes label

zmerlynn added this to the v1.2 milestone

Member Author

zmerlynn commented Jun 22, 2016

@wojtek-t: Since you did the original review, if you're still around can you spot check the cherrypick to see if I screwed up any conflicts?

Member

wojtek-t commented Jun 22, 2016

LGTM

wojtek-t added the lgtm label

zmerlynn mentioned this pull request

Automated cherry pick of #27829 #27866

Closed

k8s-github-robot commented Jun 22, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

k8s-github-robot added size/S release-note-label-needed and removed lgtm labels

zmerlynn added release-note lgtm and removed release-note-label-needed labels

k8s-github-robot commented Jun 22, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

3 similar comments

k8s-github-robot commented Jun 22, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

k8s-github-robot commented Jun 22, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

k8s-github-robot commented Jun 22, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

Member Author

zmerlynn commented Jun 22, 2016

@roberthbailey: I glanced at the first Jenkins failure and it's again the Kubectl client Simple pod should support exec through an HTTP proxy failure. Unclear why it's failing in the PR builder - the CI is green here even after checking in the last one this failed on.

Given that we're really, really closing the release-1.2 branch after this (most likely) I'm inclined to ignore this, but just a heads up to @kubernetes/test-infra-maintainers that there's sometihng fishy going on with the release branches and the PR infrastructure, and right after the release ships is probably a good time to track down what's happening (it's usually a heavy cherry-pick time).

k8s-github-robot commented Jun 22, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

2 similar comments

k8s-github-robot commented Jun 22, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

k8s-github-robot commented Jun 22, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

k8s-bot commented Jun 22, 2016

GCE e2e build/test failed for commit d930865.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

roberthbailey merged commit 7f98cfe into kubernetes:release-1.2

k8s-github-robot commented Jun 22, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

roberthbailey changed the title ~~Manual cherry pick of #27829 on release-1.2~~ GCE provider: Create TargetPool with 200 instances, then update with rest

roberthbailey changed the title ~~GCE provider: Create TargetPool with 200 instances, then update with rest~~ Manual cherry pick of #27829 on release-1.2

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request


          Merge pull request kubernetes#27865 from zmerlynn/manual-cherrypick-2…

a0fcb09

…5178

Manual cherry pick of kubernetes#27829 on release-1.2

shouhong pushed a commit to shouhong/kubernetes that referenced this pull request


          Merge pull request kubernetes#27865 from zmerlynn/manual-cherrypick-2…

ad41e43

…5178

Manual cherry pick of kubernetes#27829 on release-1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved lgtm release-note size/S