Copy and display source location prominently on Kubernetes instances #27840
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following from kubernetes#27830, this copies the source onto the instance and displays the location of it prominently (keeping the download link for anyone that just wants to curl it). Example output (this tag doesn't exist yet): --- Welcome to Kubernetes v1.4.0! You can find documentation for Kubernetes at: http://docs.kubernetes.io/ The source for this release can be found at: /usr/local/share/doc/kubernetes/kubernetes-src.tar.gz Or you can download it at: https://storage.googleapis.com/kubernetes-release/release/v1.4.0/kubernetes-src.tar.gz It is based on the Kubernetes source at: https://github.com/kubernetes/kubernetes/tree/v1.4.0 For Kubernetes copyright and licensing information, see: /usr/local/share/doc/kubernetes/LICENSES ---
zmerlynn
added
priority/critical-urgent
k8s-github-robot
added
the
size/S
zmerlynn
added
cherrypick-candidate
and removed
priority/critical-urgent
|
Overall it lgtm. But please create a cluster and ssh into the master to verify it /home/kubernetes/kubernetes-src.tar.gz file exists with correct access permission. Thanks |
|
@andyzheng0831: Yup, already done. |
andyzheng0831
added
the
lgtm
|
lgtm |
|
@k8s-bot test this: issue #IGNORE [will look it up later] |
goltermann
added
the
priority/important-soon
|
GCE e2e build/test passed for commit f9d1737. |
|
@lavalamp: Maybe we should start tracking the rejection rate for the PR builder / SQ, as signal for health. (Marking as retest-not-required, because !@#!$@.) |
|
@zmerlynn yeah that's in the exit criteria and I'm working on automating that as we speak. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Jun 23, 2016
…-node Automatic merge from submit-queue Revert "Copy and display source location prominently on Kubernetes instances" Reverts #27840 This broke cluster upgrade, ref #27764 (comment). cc @janetkuo @zmerlynn
maisem
pushed a commit
to maisem/kubernetes
that referenced
this pull request
Jun 23, 2016
Automatic merge from submit-queue Copy and display source location prominently on Kubernetes instances Following from kubernetes#27830, this copies the source onto the instance and displays the location of it prominently (keeping the download link for anyone that just wants to curl it). Example output (this tag doesn't exist yet): ``` Welcome to Kubernetes v1.4.0! You can find documentation for Kubernetes at: http://docs.kubernetes.io/ The source for this release can be found at: /usr/local/share/doc/kubernetes/kubernetes-src.tar.gz Or you can download it at: https://storage.googleapis.com/kubernetes-release/release/v1.4.0/kubernetes-src.tar.gz It is based on the Kubernetes source at: https://github.com/kubernetes/kubernetes/tree/v1.4.0 For Kubernetes copyright and licensing information, see: /usr/local/share/doc/kubernetes/LICENSES ``` []()
k8s-github-robot
pushed a commit
that referenced
this pull request
Jun 24, 2016
Automatic merge from submit-queue Copy and display source location prominently on Kubernetes instances Reapplying #27840. Following from #27830, this copies the source onto the instance and displays the location of it prominently (keeping the download link for anyone that just wants to curl it). Example output (this tag doesn't exist yet): --- Welcome to Kubernetes v1.4.0! You can find documentation for Kubernetes at: http://docs.kubernetes.io/ The source for this release can be found at: /usr/local/share/doc/kubernetes/kubernetes-src.tar.gz Or you can download it at: https://storage.googleapis.com/kubernetes-release/release/v1.4.0/kubernetes-src.tar.gz It is based on the Kubernetes source at: https://github.com/kubernetes/kubernetes/tree/v1.4.0 For Kubernetes copyright and licensing information, see: /usr/local/share/doc/kubernetes/LICENSES ----
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from #27830, this copies the source onto the instance and displays the location of it prominently (keeping the download link for anyone that just wants to curl it).
Example output (this tag doesn't exist yet):