introduce shell2junit #27825
introduce shell2junit #27825
Conversation
freehan
added
the
release-note-none
k8s-github-robot
added
the
size/L
|
kubernetes/test-infra#76 cc @kubernetes/sig-testing |
freehan
force-pushed
the
jenkinjunit
branch
2 times, most recently
from
d300d7e to
2e867fa
Compare
|
LGTM, e2e failed though? |
| noleak=false | ||
| fi | ||
| record_command "${STAGE_CLEANUP}" "resource-leak" ${noleak} | ||
| if ! ${noleak} ; then |
There was a problem hiding this comment.
This is pretty confusing. At the least switch noleak to leak and get rid of this double negation, and I'd really rather explicitly check [[ "${leak}" == "true" ]].
There was a problem hiding this comment.
That is the feature of command recorder. It will record failure if false. For true, the testcase is consider passed. That is why I reversed it.
|
I'm not super excited about adding more bash, but this is probably better than not having anytihng, so I guess this is OK. It might be helpful for the junit library if you |
|
Will close this PR and come back with another one. I will put the original lib and modifications in separate commits. |
|
You can do it in the same PR. That way we keep comments :) |
|
Ready for review. This part has to go in first because e2e-runner is a standalone script. I plan to source sh2ju library in e2e-runner using curl. |
|
ping. Can anyone LGTM? This one has to go in first. |
freehan
force-pushed
the
jenkinjunit
branch
2 times, most recently
from
feefddb to
31d1f83
Compare
|
GCE e2e build/test passed for commit 5179ad2ec7b1cdb29e419295879bca22707f61ef. |
|
Nikhil volunteered to review |
| echo "name is: $name" | ||
| echo "class is: $class" | ||
|
|
||
| # echo "name is: $name" |
There was a problem hiding this comment.
Is this intentional?
Seems fine to keep the echos for debugging
There was a problem hiding this comment.
Yeah. The lib already prints the complete command. Printing name and class are not very useful since they are from user input. And it makes the output some how crowded.
There was a problem hiding this comment.
Delete the lines then? No need to keep commented out lines.
|
One minor comment. |
|
GCE e2e build/test passed for commit ec3f0e9. |
|
LGTM, thx! |
nikhiljindal
added
the
lgtm
|
@freehan |
k8s-github-robot
removed
the
lgtm
freehan
added
the
lgtm
|
Automatic merge from submit-queue |
Automatic merge from submit-queue add junit recording in e2e runner 2nd part of #27825 Injected junit recorder at a few places.
fork shell2junit from https://github.com/manolo/shell2junit