Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mungegithub and the verification build #27797

Merged
merged 1 commit into from
Jun 21, 2016

Conversation

mikedanese
Copy link
Member

No description provided.

@lavalamp
Copy link
Member

Merge first, ask questions later.

@k8s-bot
Copy link

k8s-bot commented Jun 21, 2016

GCE e2e build/test passed for commit e26fb81.

@lavalamp
Copy link
Member

@smarterclayton fyi because this fixes something about your original change.

I'm not sure why the munger on your system didn't include this and also why the testing didn't start detecting it until just now. I think the latter was somehow triggered by the release @david-mcmahon just did.

@david-mcmahon
Copy link
Contributor

@lavalamp I'd be surprised if it was the update to the branch that caused the master munger to start failing.

@lavalamp
Copy link
Member

I think there's a git command that looks for release branches that maybe suddenly started working?

@david-mcmahon
Copy link
Contributor

david-mcmahon commented Jun 21, 2016

Yes one of the -munge- scripts actually hardcodes looking for upstream/branch, but prior to today's push the branch already existed so that wouldn't have been 'new'.

@lavalamp
Copy link
Member

Exactly-- that's why I don't understand why it would have stopped working
just now.

On Tue, Jun 21, 2016 at 2:48 PM, David McMahon notifications@github.com
wrote:

Yes one of the munge scripts actually hardcodes looking for upstream/,
but prior to today's push the already existed so that wouldn't have been
'new'.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#27797 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAnglrgKYzhjyIBOtDqEJOmh12-mjQFpks5qOFwxgaJpZM4I7Isl
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants