Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS kube-up: Authorize route53 in the IAM policy #27794

Merged
merged 1 commit into from
Jun 21, 2016
Merged

AWS kube-up: Authorize route53 in the IAM policy #27794

merged 1 commit into from
Jun 21, 2016
+10 −0

Conversation

justinsb
Copy link
Member

Federation needs this now (on the nodes), and I suspect ingress
controllers will shortly want this also. Given we're going to authorize
it on the nodes, we should authorize it on the master also (the master
is much more trusted).

Fix #27467

@justinsb
AWS kube-up: Authorize route53 in the IAM policy
f3cc5f5 
Federation needs this now (on the nodes), and I suspect ingress
controllers will shortly want this also.  Given we're going to authorize
it on the nodes, we should authorize it on the master also (the master
is much more trusted).

Fix kubernetes#27467
@justinsb
Copy link
Member Author

I've been running this policy anyway in upup...

@justinsb justinsb mentioned this pull request Jun 21, 2016
Closed
@madhusudancs madhusudancs self-assigned this Jun 21, 2016
@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2016
@madhusudancs
Copy link
Contributor

madhusudancs commented Jun 21, 2016 •
edited
Loading

LGTM! Thanks!

@madhusudancs
Copy link
Contributor

cc @kubernetes/sig-cluster-federation

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 21, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 21, 2016

GCE e2e build/test passed for commit f3cc5f5.

@ghost ghost added release-note Denotes a PR that will be considered when it comes time to generate release notes. team/control-plane priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed release-note-label-needed labels Jun 21, 2016
@ghost ghost added this to the v1.3 milestone Jun 21, 2016
@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2016
@goltermann
Copy link
Contributor

@k8s-bot verify this issue: #27797

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 21, 2016

GCE e2e build/test passed for commit f3cc5f5.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 62ce669 into kubernetes:master Jun 21, 2016
@ghost ghost mentioned this pull request Jun 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@madhusudancs madhusudancs

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@justinsb @madhusudancs @k8s-bot @goltermann @k8s-github-robot @googlebot