Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment controller's cleanupUnhealthyReplicas should respect minReadySeconds #27728

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Deployment controller's cleanupUnhealthyReplicas should respect minReadySeconds #27728

merged 1 commit into from
Jun 21, 2016
+6 −6

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Jun 20, 2016 •
edited
Loading 

Fixed an issue that Deployment may be scaled down further than allowed by maxUnavailable when minReadySeconds is set.

Fixes #26834

Detected by a flake in deployment rollover e2e test (the only test that specifies minReadySeconds).

cc @kubernetes/deployment @pwittrock
cc @mqliang who first added cleanupUnhealthyReplicas in deployment controller

Analytics

@janetkuo janetkuo added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/flake Categorizes issue or PR as related to a flaky test. labels Jun 20, 2016
@janetkuo janetkuo added this to the v1.3 milestone Jun 20, 2016
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jun 20, 2016
@0xmichalis
Copy link
Contributor

LGTM

I think you need to update tests too

@janetkuo janetkuo force-pushed the deployment-cleanup-unhealthy branch from de94905 to 726ba45 Compare June 20, 2016 22:04
@janetkuo janetkuo added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 20, 2016
@pwittrock pwittrock added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2016
@pwittrock
Copy link
Member

plz add a release note

@pwittrock pwittrock added release-note-label-needed and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 21, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2016
@janetkuo janetkuo added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jun 21, 2016
@janetkuo
Copy link
Member Author

@k8s-bot e2e test this issue: #27335

@janetkuo
Copy link
Member Author

@k8s-bot node e2e test this issue: #27788

@k8s-bot
Copy link

k8s-bot commented Jun 21, 2016

GCE e2e build/test passed for commit 726ba45.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 21, 2016

GCE e2e build/test passed for commit 726ba45.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 459757c into kubernetes:master Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0xmichalis 0xmichalis

@pwittrock pwittrock

Labels
kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@janetkuo @0xmichalis @pwittrock @k8s-bot @k8s-github-robot @googlebot