AWS: Enable ICMP Type 3 Code 4 for ELBs #27677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables MTU discovery. Fixes kubernetes#24254
justinsb
added
priority/backlog
k8s-github-robot
added
size/S
|
GCE e2e build/test passed for commit fddc9d6. |
justinsb
added
release-note
|
@justinsb seems fine, I'm not sure about this: will this modify existing sg to include the ICMP rule? In any case, it's better to have this than not have it :) Also, no one is assigned, so this might not get a lgtm and be merged. Not sure if you were aware of that |
goltermann
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit fddc9d6. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables MTU discovery.
Fixes #24254