Log ErrUnexpectedEOF from watches as warnings #2767
Merged
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watches are often established via long-running HTTP GET requests which will inevitably time out during the normal course of operations. When the watches time out, an io.EOF or an io.ErrUnexpectedEOF will bubble up to client components such as StreamWatcher and Reflector. Treat EOF as a clean watch termination. Treat ErrUnexpectedEOF as a less-clean but non-fatal watch termination and log the event at the warning level. This greatly reduces the amount of log noise generated during what is ultimately normal operation, and adds the flexibility for the operator to make a distinction between the EOF conditions if so desired (by adjusting the logging level).
|
LGTM 👍 |
bgrant0607
added a commit
that referenced
this pull request
Dec 5, 2014
Log ErrUnexpectedEOF from watches as warnings
|
Cool, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watches are often established via long-running HTTP GET requests which
will inevitably time out during the normal course of operations. When
the watches time out, an io.EOF or an io.ErrUnexpectedEOF will bubble
up to client components such as StreamWatcher and Reflector. Treat EOF
as a clean watch termination. Treat ErrUnexpectedEOF as a less-clean
but non-fatal watch termination and log the event at the warning level.
This greatly reduces the amount of log noise generated during what is
ultimately normal operation, and adds the flexibility for the operator
to make a distinction between the EOF conditions if so desired (by
adjusting the logging level).