AWS volumes: Use /dev/xvdXX names with EC2 #27628
Conversation
We are using HVM style names, which cannot be paravirtual style names. See http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/device_naming.html This also fixes problems introduced when moving volume mounting to KCM. Fix kubernetes#27534
justinsb
added
the
priority/important-soon
|
cc @simonswine I think this is all we need to do. I think that the move to supporting lots of volumes requires using xvd names when talking to the EC2 API. I think this also means that we don't support paravirtualized instance types, but that is a separate issue (I'm not sure anyone would want to run non-HVM?) |
k8s-github-robot
added
size/XS
|
GCE e2e build/test passed for commit 3af950f. |
|
LGTM Thanks @justinsb for getting this in |
|
Btw: I think a release note could be useful: cloudprovider/aws: removing support for EBS attachment for paravirtualized instances |
|
You did all the hard work @simonswine :-) I think we accidentally removed EBS attachment on paravirtualized instances in 1.2 (i.e. not sure it belongs as a release note on this PR!) Given I haven't heard anyone complaining, I guess that supports the idea that paravirtualized instances aren't too crucial. I do agree we should document it somewhere though! |
justinsb
added
release-note
davidopp
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 3af950f. |
|
Automatic merge from submit-queue |
We are using HVM style names, which cannot be paravirtual style names.
See
http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/device_naming.html
This also fixes problems introduced when moving volume mounting to KCM.
Fix #27534