-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped Heapster to v1.1.0 #27542
Bumped Heapster to v1.1.0 #27542
Conversation
cc @kubernetes/heapster-maintainers |
@@ -16,26 +16,26 @@ | |||
apiVersion: extensions/v1beta1 | |||
kind: Deployment | |||
metadata: | |||
name: heapster-v1.1.0.beta2 | |||
name: heapster-v1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please bum it also in:
https://github.com/kubernetes/kubernetes/blob/master/test/kubemark/resources/heapster_template.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Looks good from my end |
LGTM module comment from @wojtek-t |
I'm gonna add lgtm label so that it could be merged. We can fix kubemark version in a separate PR, which does not have to go the branch. |
lgtm - thanks! |
GCE e2e build/test passed for commit 8fff531. |
@thockin @bgrant0607 can we ensure that this goes into the next 1.3 beta? When is that scheduled for?? This is broken in Fridays beta, and I gotta say it sucks not having heapster when you are running 1k nodes :( Kinda feel like I am running blind. |
@chrislovecnm Since we haven't opened up master to 1.4 work yet, this'll definitely be pulled into the next release. We haven't made a call on if we produce another beta this week, as our goal for the final 1.3 release is June 24. |
@goltermann next Friday will be too late for me. I have a demo on the Monday afterward, and it takes over 24 hours to deploy the amount of pods that I am running ... May need to hack this into a release, manually. Thanks for the follow-up!!!! |
cc @erictune |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 8fff531. |
Automatic merge from submit-queue |
@chrislovecnm 1.3.0-beta.2 just released, and contains this fix. |
Yes that made me quite happy... Just have to cherry pick one pr... |
Version 1.1.0 doesn't differ from the previous one v1.1.0-beta2 significantly - just fixed few small issues during stabilization period.
cc @a-robinson @jszczepkowski @mwielgus