Retry Pod/RC updates in kubectl rolling-update #27509
Merged
+168
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janetkuo
added
priority/important-soon
k8s-github-robot
added
the
size/M
| } | ||
| } | ||
|
|
||
| const MaxRetries = 3 | ||
|
|
||
| func AddDeploymentKeyToReplicationController(oldRc *api.ReplicationController, client client.Interface, deploymentKey, deploymentValue, namespace string, out io.Writer) (*api.ReplicationController, error) { | ||
| fmt.Printf("calling AddDeploymentKeyToReplicationController\n") |
k8s-github-robot
added
size/L
janetkuo
force-pushed
the
retry-update-e2e-rolling-update
branch
from
285b8b3 to
43c096d
Compare
| } | ||
|
|
||
| // retry retries fn using exponential backoff | ||
| func retry(delay time.Duration, maxRetries int, fn func() bool) error { |
There was a problem hiding this comment.
Take a look at
. We probably want to copy this or move it into a util pkg.
There was a problem hiding this comment.
Also we should make it clear under what scenario we should retry.
janetkuo
force-pushed
the
retry-update-e2e-rolling-update
branch
3 times, most recently
from
a7a7c75 to
8b1dcdc
Compare
|
@pwittrock @Kargakis ptal |
| // 2. applyUpdate | ||
| // 3. Update the resource | ||
| func updatePodWithRetries(c client.Interface, namespace string, pod *api.Pod, applyUpdate updatePodFunc) (*api.Pod, error) { | ||
| oldPod := pod |
There was a problem hiding this comment.
I think you need to deep-copy here
0xmichalis
added
the
lgtm
|
@janetkuo squash and reapply lgtm |
0xmichalis
removed
the
lgtm
janetkuo
force-pushed
the
retry-update-e2e-rolling-update
branch
from
98f2df7 to
ee81e5e
Compare
janetkuo
added
lgtm
|
GCE e2e build/test passed for commit ee81e5e. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit ee81e5e. |
|
Automatic merge from submit-queue |
|
@Kargakis Thanks for doing the review |
roberthbailey
added
release-note
roberthbailey
added a commit
that referenced
this pull request
Jun 24, 2016
…27509-upstream-release-1.2 Automated cherry pick of #27509
|
@janetkuo I think this is already in release-1.3 branch since it merged several days ago. I'm removing the cherrypick-candidate label. Re-add if i am mistaken. |
|
@erictune - fyi the label was also there because we wanted to cherry pick this into 1.2 (which was done yesterday). It's fine to remove it as this point. |
roberthbailey
added
the
cherry-pick-approved
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…-pick-of-#27509-upstream-release-1.2 Automated cherry pick of kubernetes#27509
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…-pick-of-#27509-upstream-release-1.2 Automated cherry pick of kubernetes#27509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27328
@kubernetes/kubectl