Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet can retrieve host IP even when apiserver has not been contacted #27508

Merged
merged 2 commits into from
Jun 26, 2016
Merged

Kubelet can retrieve host IP even when apiserver has not been contacted #27508

merged 2 commits into from
Jun 26, 2016

Conversation

aaronlevy
Copy link
Contributor

@aaronlevy aaronlevy commented Jun 16, 2016 •
edited
Loading

fixes #26590, fixes #6558

Right now the kubelet expects to get the hostIP from the kubelet's local nodeInfo cache. However, this will be empty if there is no api-server (or the apiServer has not yet been contacted).

In the case of static pods, this change means the downward api can now be used to populate hostIP.

@k8s-bot
Copy link

k8s-bot commented Jun 16, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Jun 16, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Jun 16, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@aaronlevy aaronlevy mentioned this pull request Jun 16, 2016
Closed
@k8s-bot
Copy link

k8s-bot commented Jun 16, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jun 16, 2016
aaronlevy added a commit to aaronlevy/kubernetes that referenced this pull request Jun 16, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
a806b35 
Cherry-pick of: kubernetes#27508
@aaronlevy aaronlevy mentioned this pull request Jun 16, 2016
Merged
aaronlevy added a commit to aaronlevy/kubernetes that referenced this pull request Jun 17, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
50ebb16 
Cherry-pick of: kubernetes#27508
@vishh vishh self-assigned this Jun 20, 2016
@aaronlevy
Copy link
Contributor Author

This actually seems to be breaking unit tests -- looking into it now

@aaronlevy
Copy link
Contributor Author

unit test failures should be fixed.

aaronlevy added a commit to aaronlevy/kubernetes that referenced this pull request Jun 21, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
fca74c3 
Cherry-pick of: kubernetes#27508
@vishh vishh added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jun 23, 2016
@vishh
Copy link
Contributor

vishh commented Jun 23, 2016

LGTM

@k8s-bot
Copy link

k8s-bot commented Jun 23, 2016

GCE e2e build/test passed for commit 4a62d8e.

@k8s-bot
Copy link

k8s-bot commented Jun 26, 2016

GCE e2e build/test passed for commit 4a62d8e.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit a43aa60 into kubernetes:master Jun 26, 2016
@aaronlevy aaronlevy deleted the dapi-hostip branch June 27, 2016 16:38
peebs pushed a commit to peebs/kubernetes that referenced this pull request Jun 30, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
f11edc9 
Cherry-pick of: kubernetes#27508
aaronlevy added a commit to aaronlevy/kubernetes that referenced this pull request Jul 1, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
227e92a 
Cherry-pick of: kubernetes#27508
peebs pushed a commit to peebs/kubernetes that referenced this pull request Jul 1, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
9688b15 
Cherry-pick of: kubernetes#27508
mjg59 pushed a commit to mjg59/kubernetes that referenced this pull request Jul 13, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
7a7a5d4 
Cherry-pick of: kubernetes#27508
aaronlevy added a commit to aaronlevy/kubernetes that referenced this pull request Jul 18, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
d501db7 
Cherry-pick of: kubernetes#27508
peebs pushed a commit to peebs/kubernetes that referenced this pull request Jul 26, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
963083d 
backport of: kubernetes#27508
aaronlevy added a commit to aaronlevy/kubernetes that referenced this pull request Aug 1, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
c8f5f19 
backport of: kubernetes#27508
peebs pushed a commit to peebs/kubernetes that referenced this pull request Aug 12, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
7adf491 
backport of: kubernetes#27508
aaronlevy added a commit to aaronlevy/kubernetes that referenced this pull request Aug 27, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
7c7ee66 
backport of: kubernetes#27508
aaronlevy added a commit to coreos/kubernetes that referenced this pull request Sep 13, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
06d0f60 
backport of: kubernetes#27508
aaronlevy added a commit to coreos/kubernetes that referenced this pull request Sep 28, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
c0642d2 
backport of: kubernetes#27508
aaronlevy added a commit to coreos/kubernetes that referenced this pull request Oct 20, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
80c3831 
backport of: kubernetes#27508
aaronlevy added a commit to coreos/kubernetes that referenced this pull request Nov 1, 2016
@aaronlevy
Retrieve host IP in isolation from apiserver
9000f53 
backport of: kubernetes#27508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vishh vishh

@dchen1107 dchen1107

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@aaronlevy @k8s-bot @vishh @k8s-github-robot @googlebot @dchen1107