Remove duplicated nginx image. Use nginx-slim instead #27468

aledbf · 2016-06-15T20:05:53Z

This PR removes the image gcr.io/google_containers/nginx:1.7.9 and uses gcr.io/google_containers/nginx-slim:0.7.
Besides removing the duplication 1.7.9 is 16 months old.

k8s-bot · 2016-06-15T20:06:17Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-15T20:06:42Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-15T20:07:10Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-15T20:07:35Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

aledbf · 2016-06-15T20:09:43Z

ping @bprashanth

bprashanth · 2016-06-15T20:23:34Z

cluster/saltbase/salt/e2e-image-puller/e2e-image-puller.manifest

@@ -27,7 +27,7 @@ spec:
    command:
    - /bin/sh
    - -c
-    - "for i in gcr.io/google_containers/busybox gcr.io/google_containers/busybox:1.24 gcr.io/google_containers/dnsutils:e2e gcr.io/google_containers/eptest:0.1 gcr.io/google_containers/fakegitserver:0.1 gcr.io/google_containers/hostexec:1.2 gcr.io/google_containers/iperf:e2e gcr.io/google_containers/jessie-dnsutils:e2e gcr.io/google_containers/liveness:e2e gcr.io/google_containers/mounttest:0.2 gcr.io/google_containers/mounttest:0.5 gcr.io/google_containers/mounttest:0.6 gcr.io/google_containers/mounttest-user:0.3 gcr.io/google_containers/netexec:1.4 gcr.io/google_containers/netexec:1.5 gcr.io/google_containers/nettest:1.7 gcr.io/google_containers/nettest:1.8 gcr.io/google_containers/nginx:1.7.9 gcr.io/google_containers/nginx-slim:0.5 gcr.io/google_containers/n-way-http:1.0 gcr.io/google_containers/pause:2.0 gcr.io/google_containers/pause-amd64:3.0 gcr.io/google_containers/porter:cd5cb5791ebaa8641955f0e8c2a9bed669b1eaab gcr.io/google_containers/portforwardtester:1.0 gcr.io/google_containers/redis:e2e gcr.io/google_containers/resource_consumer:beta2 gcr.io/google_containers/serve_hostname:v1.4 gcr.io/google_containers/servicelb:0.1 gcr.io/google_containers/test-webserver:e2e gcr.io/google_containers/ubuntu:14.04 gcr.io/google_containers/update-demo:kitten gcr.io/google_containers/update-demo:nautilus gcr.io/google_containers/volume-ceph:0.1 gcr.io/google_containers/volume-gluster:0.2 gcr.io/google_containers/volume-iscsi:0.1 gcr.io/google_containers/volume-nfs:0.6 gcr.io/google_containers/volume-rbd:0.1 gcr.io/google_samples/gb-redisslave:v1; do echo $(date '+%X') pulling $i; docker pull $i 1>/dev/null; done; exit 0;"
+    - "for i in gcr.io/google_containers/busybox gcr.io/google_containers/busybox:1.24 gcr.io/google_containers/dnsutils:e2e gcr.io/google_containers/eptest:0.1 gcr.io/google_containers/fakegitserver:0.1 gcr.io/google_containers/hostexec:1.2 gcr.io/google_containers/iperf:e2e gcr.io/google_containers/jessie-dnsutils:e2e gcr.io/google_containers/liveness:e2e gcr.io/google_containers/mounttest:0.2 gcr.io/google_containers/mounttest:0.5 gcr.io/google_containers/mounttest:0.6 gcr.io/google_containers/mounttest-user:0.3 gcr.io/google_containers/netexec:1.4 gcr.io/google_containers/netexec:1.5 gcr.io/google_containers/nettest:1.7 gcr.io/google_containers/nettest:1.8 gcr.io/google_containers/nginx-slim:0.7 gcr.io/google_containers/n-way-http:1.0 gcr.io/google_containers/pause:2.0 gcr.io/google_containers/pause-amd64:3.0 gcr.io/google_containers/porter:cd5cb5791ebaa8641955f0e8c2a9bed669b1eaab gcr.io/google_containers/portforwardtester:1.0 gcr.io/google_containers/redis:e2e gcr.io/google_containers/resource_consumer:beta2 gcr.io/google_containers/serve_hostname:v1.4 gcr.io/google_containers/servicelb:0.1 gcr.io/google_containers/test-webserver:e2e gcr.io/google_containers/ubuntu:14.04 gcr.io/google_containers/update-demo:kitten gcr.io/google_containers/update-demo:nautilus gcr.io/google_containers/volume-ceph:0.1 gcr.io/google_containers/volume-gluster:0.2 gcr.io/google_containers/volume-iscsi:0.1 gcr.io/google_containers/volume-nfs:0.6 gcr.io/google_containers/volume-rbd:0.1 gcr.io/google_samples/gb-redisslave:v1; do echo $(date '+%X') pulling $i; docker pull $i 1>/dev/null; done; exit 0;"


can you also remove servicelb from this list? we don't run that e2e in a blocking suite so it's not worth pulling

bprashanth · 2016-06-15T20:23:53Z

Thanks for the cleanup!

aledbf · 2016-06-16T04:09:09Z

ping @bprashanth

bprashanth · 2016-06-16T17:37:52Z

@k8s-bot test this github issue: #27551

k8s-bot · 2016-06-16T18:44:35Z

GCE e2e build/test passed for commit c5cabccb208dffa9b5fe0fbd1d83044a364bfd7c.

k8s-bot · 2016-06-23T22:05:38Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-24T21:41:05Z

GCE e2e build/test failed for commit f4ee227ccacd33657d2cc157973d4d02a7e48e5c.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

bprashanth · 2016-06-25T06:24:43Z

@k8s-bot test this github issue: #27551

k8s-bot · 2016-06-25T06:57:18Z

GCE e2e build/test passed for commit f4ee227ccacd33657d2cc157973d4d02a7e48e5c.

k8s-bot · 2016-06-28T22:13:16Z

GCE e2e build/test failed for commit ec5cc59.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-06-29T14:29:55Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-29T15:01:27Z

GCE e2e build/test passed for commit ec5cc59.

k8s-github-robot · 2016-06-29T19:09:56Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-06-29T19:43:34Z

GCE e2e build/test passed for commit ec5cc59.

k8s-github-robot · 2016-06-29T19:43:38Z

Automatic merge from submit-queue

googlebot added the cla: yes label Jun 15, 2016

k8s-github-robot assigned zmerlynn Jun 15, 2016

k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jun 15, 2016

bprashanth reviewed Jun 15, 2016
View reviewed changes

bprashanth added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2016

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2016

aledbf force-pushed the remove-duplicated-nginx-image branch from 060aaf3 to 9271192 Compare June 15, 2016 20:25

bprashanth added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 15, 2016

aledbf force-pushed the remove-duplicated-nginx-image branch from 9271192 to 169af60 Compare June 16, 2016 02:28

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2016

bprashanth added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2016

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2016

aledbf force-pushed the remove-duplicated-nginx-image branch from 169af60 to c5cabcc Compare June 16, 2016 11:06

k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 16, 2016

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2016

aledbf force-pushed the remove-duplicated-nginx-image branch from c5cabcc to f4ee227 Compare June 24, 2016 21:14

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2016

bprashanth added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2016

Remove duplicated nginx image. Use nginx-slim

ec5cc59

aledbf force-pushed the remove-duplicated-nginx-image branch from f4ee227 to ec5cc59 Compare June 28, 2016 21:35

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2016

bprashanth added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2016

k8s-github-robot merged commit 594e4d8 into kubernetes:master Jun 29, 2016

aledbf deleted the remove-duplicated-nginx-image branch July 15, 2016 15:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove duplicated nginx image. Use nginx-slim instead #27468

Remove duplicated nginx image. Use nginx-slim instead #27468

aledbf commented Jun 15, 2016

k8s-bot commented Jun 15, 2016

k8s-bot commented Jun 15, 2016

k8s-bot commented Jun 15, 2016

k8s-bot commented Jun 15, 2016

aledbf commented Jun 15, 2016

bprashanth Jun 15, 2016

aledbf Jun 15, 2016

bprashanth commented Jun 15, 2016

aledbf commented Jun 16, 2016

bprashanth commented Jun 16, 2016

k8s-bot commented Jun 16, 2016

k8s-bot commented Jun 23, 2016

k8s-bot commented Jun 24, 2016

bprashanth commented Jun 25, 2016 •

edited

Loading

k8s-bot commented Jun 25, 2016

k8s-bot commented Jun 28, 2016

k8s-bot commented Jun 29, 2016

k8s-bot commented Jun 29, 2016

k8s-github-robot commented Jun 29, 2016

k8s-bot commented Jun 29, 2016

k8s-github-robot commented Jun 29, 2016

Remove duplicated nginx image. Use nginx-slim instead #27468

Remove duplicated nginx image. Use nginx-slim instead #27468

Conversation

aledbf commented Jun 15, 2016

k8s-bot commented Jun 15, 2016

k8s-bot commented Jun 15, 2016

k8s-bot commented Jun 15, 2016

k8s-bot commented Jun 15, 2016

aledbf commented Jun 15, 2016

bprashanth Jun 15, 2016

Choose a reason for hiding this comment

aledbf Jun 15, 2016

Choose a reason for hiding this comment

bprashanth commented Jun 15, 2016

aledbf commented Jun 16, 2016

bprashanth commented Jun 16, 2016

k8s-bot commented Jun 16, 2016

k8s-bot commented Jun 23, 2016

k8s-bot commented Jun 24, 2016

bprashanth commented Jun 25, 2016 • edited Loading

k8s-bot commented Jun 25, 2016

k8s-bot commented Jun 28, 2016

k8s-bot commented Jun 29, 2016

k8s-bot commented Jun 29, 2016

k8s-github-robot commented Jun 29, 2016

k8s-bot commented Jun 29, 2016

k8s-github-robot commented Jun 29, 2016

bprashanth commented Jun 25, 2016 •

edited

Loading